From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix vinyl/errinj_stat failure
Date: Wed, 10 Apr 2019 16:53:32 +0300 [thread overview]
Message-ID: <20190410135332.bcbrbeipw55nzaxb@esperanza> (raw)
In-Reply-To: <f4b80bcf4908442c98f9d16538b7d792f92bd40e.1554904342.git.vdavydov.dev@gmail.com>
On Wed, Apr 10, 2019 at 04:52:50PM +0300, Vladimir Davydov wrote:
> The patch fixes the following test failures:
>
> | [022] --- vinyl/errinj_stat.result Tue Mar 19 17:52:48 2019
> | [022] +++ vinyl/errinj_stat.reject Wed Mar 20 08:08:41 2019
> | [022] @@ -229,7 +229,7 @@
> | [022] ...
> | [022] stat.tasks_inprogress == 0
> | [022] ---
> | [022] -- true
> | [022] +- false
> | [022] ...
> | [022] stat.tasks_completed == 1
> | [022] ---
>
> | [013] --- vinyl/errinj_stat.result Tue Mar 19 17:52:48 2019
> | [013] +++ vinyl/errinj_stat.reject Wed Mar 20 08:11:15 2019
> | [013] @@ -168,7 +168,7 @@
> | [013] ...
> | [013] stat.tasks_inprogress > 0
> | [013] ---
> | [013] -- true
> | [013] +- false
> | [013] ...
> | [013] stat.tasks_completed == 0
> | [013] ---
> | [013] @@ -183,7 +183,7 @@
> | [013] ...
> | [013] box.stat.vinyl().scheduler.tasks_inprogress > 0
> | [013] ---
> | [013] -- true
> | [013] +- false
> | [013] ...
> | [013] errinj.set('ERRINJ_VY_RUN_WRITE_DELAY', false)
> | [013] ---
>
> The problem occurred, because the test didn't make sure that an
> asynchronous dump/compaction task has actually started/completed.
> Even box.snapshot() doesn't guarantee that a dump task is complete,
> in fact. This patch adds wait_cond's to guarantee the test never
> fails like that anymore.
>
> Closes #4059
> Closes #4060
> ---
> test/vinyl/errinj_stat.result | 52 +++++++++++++++++++++++++++++------------
> test/vinyl/errinj_stat.test.lua | 25 ++++++++++++--------
> 2 files changed, 52 insertions(+), 25 deletions(-)
Pushed to master.
prev parent reply other threads:[~2019-04-10 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 13:52 Vladimir Davydov
2019-04-10 13:53 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410135332.bcbrbeipw55nzaxb@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] test: fix vinyl/errinj_stat failure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox