From: Alexander Turenko <alexander.turenko@tarantool.org> To: avtikhon <avtikhon@tarantool.org> Cc: avtikhon <avtikhon@gmail.com>, tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v1 1/6] Update the timeouts, set to use the default value Date: Wed, 10 Apr 2019 15:32:22 +0300 [thread overview] Message-ID: <20190410123221.qj4e3nj6w4khdhfx@tkn_work_nb> (raw) In-Reply-To: <e8298e8dce4a9de5c53cff304da9c9af294c5434.1554127720.git.avtikhon@gmail.com> > -- Check that garbage collection removed the snapshot once > -- the replica released the corresponding checkpoint. > -wait_gc(1) or box.info.gc() > -wait_xlog(1) or fio.listdir('./master') -- Make sure the replica will not receive data until > +wait_gc(1) > +wait_xlog(1) > -- we test garbage collection. This is the poorly formatted comment that spread across two lines: -- Make sure the replica will not receive data until -- we test garbage collection. Please, add it back. > diff --git a/test/replication/master.lua b/test/replication/master.lua > index 9b96b7891..340b9cc81 100644 > --- a/test/replication/master.lua > +++ b/test/replication/master.lua > @@ -3,7 +3,7 @@ os = require('os') > box.cfg({ > listen = os.getenv("LISTEN"), > memtx_memory = 107374182, > - replication_connect_timeout = 0.5, > + replication_connect_timeout = 100, > replication_timeout = 0.1 > }) > replication_connect_timeout = 30 is not enough? > diff --git a/test/replication/master_quorum.lua b/test/replication/master_quorum.lua > index 05272ac5e..e00f1f932 100644 > --- a/test/replication/master_quorum.lua > +++ b/test/replication/master_quorum.lua > @@ -6,7 +6,7 @@ local INSTANCE_ID = string.match(arg[0], "%d") > local SOCKET_DIR = require('fio').cwd() > > local TIMEOUT = tonumber(arg[1]) > -local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 30.0 > +local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 60.0 > > local function instance_uri(instance_id) > --return 'localhost:'..(3310 + instance_id) > diff --git a/test/replication/on_replace.lua b/test/replication/on_replace.lua > index 40c12a9ea..93544afbe 100644 > --- a/test/replication/on_replace.lua > +++ b/test/replication/on_replace.lua > @@ -7,7 +7,7 @@ local PASSWORD = 'somepassword' > local SOCKET_DIR = require('fio').cwd() > > local TIMEOUT = tonumber(arg[1]) > -local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 30.0 > +local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 60.0 Really? 30 in not enough? Maybe we just increase a propability that another problem will be passed through? > -test_run:cmd('start server quorum1 with args="0.1 0.5"') > +test_run:cmd('start server quorum1 with args="0.1 0.5"') Should not we drop latter argument here too to use default 30 seconds replication_connect_timeout? > diff --git a/test/replication/rebootstrap.lua b/test/replication/rebootstrap.lua > index 3e7d8f062..472dbe453 100644 > --- a/test/replication/rebootstrap.lua > +++ b/test/replication/rebootstrap.lua > @@ -6,7 +6,7 @@ local INSTANCE_ID = string.match(arg[0], "%d") > local SOCKET_DIR = require('fio').cwd() > > local TIMEOUT = tonumber(arg[1]) > -local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 30.0 > +local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 60.0 Same question as above. > @@ -131,9 +131,9 @@ box.info.ro -- false > -- ER_CFG "duplicate connection with the same replica UUID" error. > -- It should print it to the log, but keep trying to synchronize. > -- Eventually, it should leave box.cfg() following the master. > -box.cfg{replication_timeout = 0.1} > -box.cfg{replication_sync_lag = 1} > -box.cfg{replication_sync_timeout = 10} > +box.cfg{replication_timeout = 0.01} > +box.cfg{replication_sync_lag = 0.1} > +box.cfg{replication_sync_timeout = 50} Don't get why replication_timeout and replication_sync_lag was decreased.
prev parent reply other threads:[~2019-04-10 12:32 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-01 14:13 [tarantool-patches] " avtikhon 2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 2/6] Insert status calls inside wait_cond routines avtikhon 2019-04-10 12:26 ` [tarantool-patches] " Alexander Turenko 2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 3/6] Rename replicas to the each test specified name avtikhon 2021-05-26 21:02 ` [Tarantool-patches] " Alexander Turenko via Tarantool-patches 2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 4/6] Removed unused variable avtikhon 2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 5/6] Test misc tunning avtikhon 2019-04-10 12:29 ` [tarantool-patches] " Alexander Turenko 2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 6/6] Fix wait_fullmesh avtikhon 2019-04-10 12:32 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190410123221.qj4e3nj6w4khdhfx@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@gmail.com \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/6] Update the timeouts, set to use the default value' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox