Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: avtikhon <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1] test: use unix sockets iproto
Date: Sun, 7 Apr 2019 10:28:59 +0300	[thread overview]
Message-ID: <20190407072859.rit3bxatkvgn5rfq@tkn_work_nb> (raw)
In-Reply-To: <94c6bd7f591a74c519e919612f3091577f8bcca6.1554367686.git.avtikhon@tarantool.org>

Hi!

Please, do self-review before send a patch. I'm sure you would ask the
same questions that I asked below and either fix them or describe
reasons in the commit message.

WBR, Alexander Turenko.

On Thu, Apr 04, 2019 at 11:49:50AM +0300, avtikhon wrote:
> Set to use unix sockets iproto instead of TCP sockets.

A reason? Yep, I know, it is avoiding 'Address already in use' errors.
And I know that it is because port checking in test-run is not
sufficient and races are possible. But a reader of your commit unlikely
have enough context.

It worth to add a link to related test-run issue here.

And don't forget to add fixes / closes #xxxx and the end of a commit
message.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> Issue: https://github.com/tarantool/tarantool/issues/4008

> diff --git a/test/vinyl/replica_rejoin.lua b/test/vinyl/replica_rejoin.lua
> index 7cb7e09a4..9b95d50aa 100644
> --- a/test/vinyl/replica_rejoin.lua
> +++ b/test/vinyl/replica_rejoin.lua
> @@ -7,7 +7,7 @@ end
>  
>  box.cfg({
>      replication     = replication,
> -    vinyl_memory    = 1024 * 1024,
> +    vinyl_memory    = 107374182,
>  })

How it related to the patch?

>  require('console').listen(os.getenv('ADMIN'))
> diff --git a/test/vinyl/replica_rejoin.result b/test/vinyl/replica_rejoin.result
> index 1dfcb91b8..f590e05b2 100644
> --- a/test/vinyl/replica_rejoin.result
> +++ b/test/vinyl/replica_rejoin.result
> @@ -51,8 +51,6 @@ fio.glob(fio.pathjoin(box.space.test.id, 0, '*'))
>  ---
>  - - 9000/0/00000000000000000002.index
>    - 9000/0/00000000000000000002.run
> -  - 9000/0/00000000000000000004.index
> -  - 9000/0/00000000000000000004.run

And this.

  reply	other threads:[~2019-04-07  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04  8:49 [tarantool-patches] " avtikhon
2019-04-07  7:28 ` Alexander Turenko [this message]
2019-06-05 11:32 Alexander V. Tikhonov
2019-06-07  3:14 ` [tarantool-patches] " Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190407072859.rit3bxatkvgn5rfq@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1] test: use unix sockets iproto' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox