From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables.
Date: Fri, 5 Apr 2019 14:36:50 +0300 [thread overview]
Message-ID: <20190405113650.fhvtl7o7baoj6rtc@tarantool.org> (raw)
In-Reply-To: <cover.1554310018.git.imeevma@gmail.com>
Hello,
On 03 Apr 19:58, imeevma@tarantool.org wrote:
> System tables _sql_stat1 and _sql_stat4 become unused and should
> be dropped.
>
> This patch breaks backward compatibility!
>
> https://github.com/tarantool/tarantool/issues/2843
> https://github.com/tarantool/tarantool/tree/imeevma/gh-2843-drop-_sql_stat-tables
>
> v1:
> https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-remove-sql-stat1-and-sql-stat4-system-tables
>
> Changes in new version:
> 1) Original patch divided into three.
> 2) A bit changed commit message and comments.
>
> Mergen Imeev (3):
> sql: allocate memory for index_id in VDBE
> sql: remove space_by_id() from analyze.c
> box: remove _sql_stat1 and _sql_stat4 system tables
I've checked your patches into master and 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-04-05 11:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:58 imeevma
2019-04-03 16:58 ` [PATCH v2 1/3] sql: allocate memory for index_id in VDBE imeevma
2019-04-04 16:00 ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 2/3] sql: remove space_by_id() from analyze.c imeevma
2019-04-04 16:03 ` Vladimir Davydov
2019-04-04 17:41 ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables imeevma
2019-04-03 17:19 ` Vladimir Davydov
2019-04-03 17:38 ` Re[2]: " Мерген Имеев
2019-04-03 17:58 ` Vladimir Davydov
2019-04-03 18:04 ` [tarantool-patches] Re: [tarantool-patches] " Мерген Имеев
2019-04-04 16:11 ` Vladimir Davydov
2019-04-04 18:18 ` Mergen Imeev
2019-04-05 11:36 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405113650.fhvtl7o7baoj6rtc@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox