From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: fix perf degradation on name normalization
Date: Fri, 5 Apr 2019 14:33:10 +0300 [thread overview]
Message-ID: <20190405113310.wg6fdu54ah7cxazv@tarantool.org> (raw)
In-Reply-To: <09c8ef39eaf35ae7fa6825236a3b32b54d13dec5.1554386791.git.kshcherbatov@tarantool.org>
Hello,
On 04 Apr 17:07, Kirill Shcherbatov wrote:
> Because sql_normalize_name used to be called twice - to estimate
> the size of the name buffer and to process data querying the
> UCaseMap object each time DDL performance felt by 15%.
>
> This patch should eliminate some of the negative effects of using
> ICU for name normalization.
>
> Thanks @avtikhon for a bechmark
>
> Follow up e7558062d3559e6bcc18f91eacb88269428321dc
I've checked yout patch into master and 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-04-05 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 14:07 [tarantool-patches] " Kirill Shcherbatov
2019-04-04 15:03 ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-04 17:12 ` Kirill Shcherbatov
2019-04-04 17:31 ` Vladislav Shpilevoy
2019-04-04 18:08 ` Kirill Shcherbatov
2019-04-04 20:15 ` Vladislav Shpilevoy
2019-04-05 11:33 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405113310.wg6fdu54ah7cxazv@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: fix perf degradation on name normalization' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox