From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 2/3] sql: remove space_by_id() from analyze.c
Date: Thu, 4 Apr 2019 20:41:43 +0300 [thread overview]
Message-ID: <20190404174143.fe2uhk4zhhi2wyvt@esperanza> (raw)
In-Reply-To: <20190404160349.in3vt4f4kla57eze@esperanza>
On Thu, Apr 04, 2019 at 07:03:49PM +0300, Vladimir Davydov wrote:
> On Wed, Apr 03, 2019 at 07:58:34PM +0300, imeevma@tarantool.org wrote:
> > diff --git a/src/box/sql/build.c b/src/box/sql/build.c
> > index c475b34..a06ba3e 100644
> > --- a/src/box/sql/build.c
> > +++ b/src/box/sql/build.c
> > @@ -1384,23 +1384,6 @@ vdbe_emit_stat_space_clear(struct Parse *parse, const char *stat_table_name,
> > }
> >
> > /**
> > - * Remove entries from the _sql_stat1 and _sql_stat4
> > - * system spaces after a DROP INDEX or DROP TABLE command.
> > - *
> > - * @param parse The parsing context.
> > - * @param table_name The table to be dropped or
> > - * the table that contains index to be dropped.
> > - * @param idx_name Index to be dropped.
> > - */
> > -static void
> > -sql_clear_stat_spaces(struct Parse *parse, const char *table_name,
> > - const char *idx_name)
> > -{
> > - vdbe_emit_stat_space_clear(parse, "_sql_stat4", idx_name, table_name);
> > - vdbe_emit_stat_space_clear(parse, "_sql_stat1", idx_name, table_name);
> > -}
>
> I would leave this function and instead comment its body so that we
> don't forget to resurrect this code when we reimplement stat tables.
> Other than that, looks good to me.
On the second thought, it doesn't make much sense to leave this function
as we'll have to rewrite it anyway when we reintroduce stat tables. And
it's pretty obvious that we should clear stat entries on space/index
drop so there's no need in this placeholder.
That said, the patch is okay to commit as is IMO.
next prev parent reply other threads:[~2019-04-04 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:58 [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables imeevma
2019-04-03 16:58 ` [PATCH v2 1/3] sql: allocate memory for index_id in VDBE imeevma
2019-04-04 16:00 ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 2/3] sql: remove space_by_id() from analyze.c imeevma
2019-04-04 16:03 ` Vladimir Davydov
2019-04-04 17:41 ` Vladimir Davydov [this message]
2019-04-03 16:58 ` [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables imeevma
2019-04-03 17:19 ` Vladimir Davydov
2019-04-03 17:38 ` Re[2]: " Мерген Имеев
2019-04-03 17:58 ` Vladimir Davydov
2019-04-03 18:04 ` [tarantool-patches] Re: [tarantool-patches] " Мерген Имеев
2019-04-04 16:11 ` Vladimir Davydov
2019-04-04 18:18 ` Mergen Imeev
2019-04-05 11:36 ` [tarantool-patches] [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404174143.fe2uhk4zhhi2wyvt@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2 2/3] sql: remove space_by_id() from analyze.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox