From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables
Date: Thu, 4 Apr 2019 19:11:20 +0300 [thread overview]
Message-ID: <20190404161120.lycknoar6elfh3ct@esperanza> (raw)
In-Reply-To: <8907dd9a025b0cafe9858289e4e3e2d64618f12b.1554310018.git.imeevma@gmail.com>
On Wed, Apr 03, 2019 at 07:58:38PM +0300, imeevma@tarantool.org wrote:
> New version:
>
> commit 8907dd9a025b0cafe9858289e4e3e2d64618f12b
> Author: Mergen Imeev <imeevma@gmail.com>
> Date: Wed Apr 3 19:05:09 2019 +0300
When you insert a patch into an email like this, please use
`git show --format=email` so that one can apply it.
>
> box: remove _sql_stat1 and _sql_stat4 system tables
>
> These tables won't be used anymore and should be deleted.
>
> This patch breaks backward compatibility.
This statement deserves an explanation:
Note, this patch breaks backward compatibility between 2.1.1 and 2.1.2,
but that's okay as 2.1.1 was beta and we didn't recommend anyone to use
it.
Or something like this.
The patch itself is okay although I'd squash it with patch 2.
next prev parent reply other threads:[~2019-04-04 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:58 [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables imeevma
2019-04-03 16:58 ` [PATCH v2 1/3] sql: allocate memory for index_id in VDBE imeevma
2019-04-04 16:00 ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 2/3] sql: remove space_by_id() from analyze.c imeevma
2019-04-04 16:03 ` Vladimir Davydov
2019-04-04 17:41 ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables imeevma
2019-04-03 17:19 ` Vladimir Davydov
2019-04-03 17:38 ` Re[2]: " Мерген Имеев
2019-04-03 17:58 ` Vladimir Davydov
2019-04-03 18:04 ` [tarantool-patches] Re: [tarantool-patches] " Мерген Имеев
2019-04-04 16:11 ` Vladimir Davydov [this message]
2019-04-04 18:18 ` Mergen Imeev
2019-04-05 11:36 ` [tarantool-patches] [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404161120.lycknoar6elfh3ct@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox