From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] Implement mp_stack_top for mp_stack class
Date: Thu, 4 Apr 2019 18:42:04 +0300 [thread overview]
Message-ID: <20190404154204.nthzbpfzw2ocek5p@esperanza> (raw)
In-Reply-To: <62477fef-d2fc-9559-30f4-36d03a9b70db@tarantool.org>
On Wed, Apr 03, 2019 at 08:49:23PM +0300, Kirill Shcherbatov wrote:
> @@ -2349,6 +2337,12 @@ mp_stack_is_full(struct mp_stack *stack)
> return stack->used >= stack->size;
> }
>
> +MP_IMPL struct mp_frame *
> +mp_stack_top(struct mp_stack *stack)
> +{
Nit:
assert(!mp_stack_is_empty(stack));
> + return &stack->frames[stack->used - 1];
> +}
Other than that, the patch looks good, BUT for some reason it doesn't
compile on CentOS 6 on Travis, see
https://travis-ci.org/tarantool/msgpuck/jobs/515314874
It fails with
BFD: /build/BUILDROOT/msgpuck-2.0.23-1.el6.x86_64/usr/lib64/libmsgpuck.a(msgpuck.c.o): invalid relocation type 42
Please figure out why is that and fix if possible.
next prev parent reply other threads:[~2019-04-04 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 15:49 Kirill Shcherbatov
2019-04-03 12:12 ` Vladimir Davydov
2019-04-03 15:16 ` [tarantool-patches] " Kirill Shcherbatov
2019-04-03 15:40 ` Vladimir Davydov
2019-04-03 17:49 ` Kirill Shcherbatov
2019-04-04 15:42 ` Vladimir Davydov [this message]
2019-04-05 17:17 ` Kirill Shcherbatov
2019-04-07 12:02 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404154204.nthzbpfzw2ocek5p@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH v1 1/1] Implement mp_stack_top for mp_stack class' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox