From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v2 1/2] lua: add luaT_tuple_new()
Date: Thu, 4 Apr 2019 11:14:42 +0300 [thread overview]
Message-ID: <20190404081442.zorje2f3w3m2eiyx@esperanza> (raw)
In-Reply-To: <20190404025122.766bkifzjqyjrrk5@tkn_work_nb>
On Thu, Apr 04, 2019 at 05:51:22AM +0300, Alexander Turenko wrote:
> On Wed, Apr 03, 2019 at 09:01:23PM +0300, Vladimir Davydov wrote:
> > On Wed, Mar 27, 2019 at 05:29:27PM +0300, Kirill Shcherbatov wrote:
> > > From: Alexander Turenko <alexander.turenko@tarantool.org>
> > >
> > > The function allows to create a tuple with specific tuple format in C
> > > code using a Lua table, another tuple, or objects on a Lua stack.
> > >
> > > Needed for #3276, #3398, #4025
> > > ---
> > > src/box/lua/space.cc | 7 +-
> > > src/box/lua/tuple.c | 58 +++++++----
> > > src/box/lua/tuple.h | 15 ++-
> > > test/unit/CMakeLists.txt | 4 +
> > > test/unit/luaT_tuple_new.c | 178 ++++++++++++++++++++++++++++++++
> > > test/unit/luaT_tuple_new.result | 22 ++++
> > > 6 files changed, 261 insertions(+), 23 deletions(-)
> > > create mode 100644 test/unit/luaT_tuple_new.c
> > > create mode 100644 test/unit/luaT_tuple_new.result
> >
> > Pushed to master.
>
> Thanks!
You're welcome)
>
> Are there any problems with pushing to 2.1 and 1.10? I need this for
> merger, which is planned to land into 1.10.
Let's think about backporting this patch to 2.1 and 1.10 after we push
the merger to master.
next prev parent reply other threads:[~2019-04-04 8:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 14:29 [tarantool-patches] [PATCH v2 0/2] lua: add key_def lua module Kirill Shcherbatov
2019-03-27 14:29 ` [tarantool-patches] [PATCH v2 1/2] lua: add luaT_tuple_new() Kirill Shcherbatov
2019-03-28 9:01 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 9:18 ` Alexander Turenko
2019-04-03 18:01 ` [tarantool-patches] " Vladimir Davydov
2019-04-04 2:51 ` Alexander Turenko
2019-04-04 8:14 ` Vladimir Davydov [this message]
2019-03-27 14:29 ` [tarantool-patches] [PATCH v2 2/2] lua: add key_def lua module Kirill Shcherbatov
2019-03-28 2:01 ` Alexander Turenko
2019-03-28 7:38 ` [tarantool-patches] " Kirill Shcherbatov
2019-03-28 8:41 ` Kirill Shcherbatov
[not found] ` <6d915212-e80f-4a6d-d884-b838bf25f8a7@tarantool.org>
2019-03-28 11:22 ` Alexander Turenko
2019-04-03 11:10 ` Vladimir Davydov
2019-04-03 11:46 ` Alexander Turenko
2019-04-03 12:01 ` Vladimir Davydov
2019-04-03 13:26 ` Alexander Turenko
2019-04-04 5:07 ` Alexander Turenko
2019-04-04 8:04 ` Kirill Shcherbatov
2019-04-04 9:05 ` Vladimir Davydov
2019-04-04 11:46 ` Alexander Turenko
2019-04-04 14:36 ` Vladimir Davydov
2019-04-04 8:38 ` Vladimir Davydov
2019-04-04 11:17 ` Alexander Turenko
2019-04-04 12:00 ` Alexander Turenko
2019-04-04 14:42 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404081442.zorje2f3w3m2eiyx@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2 1/2] lua: add luaT_tuple_new()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox