Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Мерген Имеев" <imeevma@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables
Date: Wed, 3 Apr 2019 20:58:17 +0300	[thread overview]
Message-ID: <20190403175817.wqtkovz54gkgcri5@esperanza> (raw)
In-Reply-To: <1554313125.704285481@f536.i.mail.ru>

On Wed, Apr 03, 2019 at 08:38:45PM +0300, Мерген Имеев wrote:
> 
> 
> 
> >Среда,  3 апреля 2019, 20:19 +03:00 от Vladimir Davydov <vdavydov.dev@gmail.com>:
> >
> >On Wed, Apr 03, 2019 at 07:58:38PM +0300,  imeevma@tarantool.org wrote:
> >> >> diff --git a/src/box/sql.c b/src/box/sql.c
> >> >> index 4fac020..7beeee1 100644
> >> >> --- a/src/box/sql.c
> >> >> +++ b/src/box/sql.c
> >> >> @@ -87,7 +87,7 @@ sql_load_schema()
> >> >>  	 * statistics (_sql_stat1 and _sql_stat4). Thus, we can
> >> >>  	 * skip statistics loading.
> >> >>  	 */
> >> >> -	struct space *stat = space_by_id(BOX_SQL_STAT1_ID);
> >> >> +	struct space *stat = space_by_name("_sql_stat1");
> >> >
> >> > I don't understand this change: even though you removed the tables you
> >> > still expect them to be accessible by name here and in a few other
> >> > places. At any rate, the comment above needs to be refreshed.
> >> >
> >> I did this to free BOX_SQL_STAT1_ID and BOX_SQL_STAT4_ID so I
> >> could remove them. These functions are currently unused. Moved
> >> this fix to a different commit.
> >
> >Okay. Still, I don't understand how this is supposed to work at all:
> >the tables have been removed, but the code using them is still there -
> >it just refers to them by name instead of id now.
> Currently I do not know how to change these functions in another
> way, since there are no spaces to use instead of _sql_stat1 and
> _sql_stat4. I will rework these functions later when a new concept
> of SQL statistics appears.

That is, these functions aren't supposed to run, right?
If so, it's okay to fix it as you did, I guess.

  reply	other threads:[~2019-04-03 17:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 16:58 [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables imeevma
2019-04-03 16:58 ` [PATCH v2 1/3] sql: allocate memory for index_id in VDBE imeevma
2019-04-04 16:00   ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 2/3] sql: remove space_by_id() from analyze.c imeevma
2019-04-04 16:03   ` Vladimir Davydov
2019-04-04 17:41     ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables imeevma
2019-04-03 17:19   ` Vladimir Davydov
2019-04-03 17:38     ` Re[2]: " Мерген Имеев
2019-04-03 17:58       ` Vladimir Davydov [this message]
2019-04-03 18:04         ` [tarantool-patches] Re: [tarantool-patches] " Мерген Имеев
2019-04-04 16:11   ` Vladimir Davydov
2019-04-04 18:18     ` Mergen Imeev
2019-04-05 11:36 ` [tarantool-patches] [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403175817.wqtkovz54gkgcri5@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox