Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH] test: temporary disable sql-tap/collation_unicode
@ 2019-04-03  0:21 Alexander Turenko
  2019-04-03  0:31 ` [tarantool-patches] " Alexander Turenko
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Turenko @ 2019-04-03  0:21 UTC (permalink / raw)
  To: tarantool-patches; +Cc: Alexander Turenko, Stanislav Zudin

The test was introduced in a99d7a0c0f6a16f0f51be532f0543e3fe1f9c97b
('Feature request for a new collation'). It succeeds when tarantool is
linked with a fresh libicu version, but fails with older ones. At least:

* dev-libs/icu-63.1-r1 (Gentoo) -- passes;
* libicu.x86_64 50.1.2-15.el7 (CentOS 7.4) -- fails.

We need to handle different behaviours of libicu versions somehow, maybe
add only stable subset of collations. This will also fix the test and
then it will be enabled back.

Related to #4007.
---

https://github.com/tarantool/tarantool/issues/4007
https://github.com/tarantool/tarantool/tree/Totktonada/disable-collation-unicode-test

 test/sql-tap/suite.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
index 95207f439..e3e483851 100644
--- a/test/sql-tap/suite.ini
+++ b/test/sql-tap/suite.ini
@@ -20,6 +20,7 @@ disabled = selectA.test.lua ;
            analyzeD.test.lua ;
            analyzeE.test.lua ;
            analyzeF.test.lua ;
+           collation_unicode.test.lua ;
 
 lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
 is_parallel = True
-- 
2.20.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tarantool-patches] Re: [PATCH] test: temporary disable sql-tap/collation_unicode
  2019-04-03  0:21 [tarantool-patches] [PATCH] test: temporary disable sql-tap/collation_unicode Alexander Turenko
@ 2019-04-03  0:31 ` Alexander Turenko
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Turenko @ 2019-04-03  0:31 UTC (permalink / raw)
  To: tarantool-patches; +Cc: Stanislav Zudin

Pushed to master and 2.1.

Reopened the issue.

WBR, Alexander Turenko.

On Wed, Apr 03, 2019 at 03:21:15AM +0300, Alexander Turenko wrote:
> The test was introduced in a99d7a0c0f6a16f0f51be532f0543e3fe1f9c97b
> ('Feature request for a new collation'). It succeeds when tarantool is
> linked with a fresh libicu version, but fails with older ones. At least:
> 
> * dev-libs/icu-63.1-r1 (Gentoo) -- passes;
> * libicu.x86_64 50.1.2-15.el7 (CentOS 7.4) -- fails.
> 
> We need to handle different behaviours of libicu versions somehow, maybe
> add only stable subset of collations. This will also fix the test and
> then it will be enabled back.
> 
> Related to #4007.
> ---
> 
> https://github.com/tarantool/tarantool/issues/4007
> https://github.com/tarantool/tarantool/tree/Totktonada/disable-collation-unicode-test
> 
>  test/sql-tap/suite.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 95207f439..e3e483851 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -20,6 +20,7 @@ disabled = selectA.test.lua ;
>             analyzeD.test.lua ;
>             analyzeE.test.lua ;
>             analyzeF.test.lua ;
> +           collation_unicode.test.lua ;
>  
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-03  0:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03  0:21 [tarantool-patches] [PATCH] test: temporary disable sql-tap/collation_unicode Alexander Turenko
2019-04-03  0:31 ` [tarantool-patches] " Alexander Turenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox