Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Stanislav Zudin <szudin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] test: temporary disable sql-tap/collation_unicode
Date: Wed, 3 Apr 2019 03:31:00 +0300	[thread overview]
Message-ID: <20190403003100.kcnjj3rdar5jifg2@tkn_work_nb> (raw)
In-Reply-To: <4dfa31f79de0d2f294fc484dbbb2b89cf7c57a11.1554250634.git.alexander.turenko@tarantool.org>

Pushed to master and 2.1.

Reopened the issue.

WBR, Alexander Turenko.

On Wed, Apr 03, 2019 at 03:21:15AM +0300, Alexander Turenko wrote:
> The test was introduced in a99d7a0c0f6a16f0f51be532f0543e3fe1f9c97b
> ('Feature request for a new collation'). It succeeds when tarantool is
> linked with a fresh libicu version, but fails with older ones. At least:
> 
> * dev-libs/icu-63.1-r1 (Gentoo) -- passes;
> * libicu.x86_64 50.1.2-15.el7 (CentOS 7.4) -- fails.
> 
> We need to handle different behaviours of libicu versions somehow, maybe
> add only stable subset of collations. This will also fix the test and
> then it will be enabled back.
> 
> Related to #4007.
> ---
> 
> https://github.com/tarantool/tarantool/issues/4007
> https://github.com/tarantool/tarantool/tree/Totktonada/disable-collation-unicode-test
> 
>  test/sql-tap/suite.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini
> index 95207f439..e3e483851 100644
> --- a/test/sql-tap/suite.ini
> +++ b/test/sql-tap/suite.ini
> @@ -20,6 +20,7 @@ disabled = selectA.test.lua ;
>             analyzeD.test.lua ;
>             analyzeE.test.lua ;
>             analyzeF.test.lua ;
> +           collation_unicode.test.lua ;
>  
>  lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua
>  is_parallel = True
> -- 
> 2.20.1
> 

      reply	other threads:[~2019-04-03  0:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  0:21 [tarantool-patches] " Alexander Turenko
2019-04-03  0:31 ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403003100.kcnjj3rdar5jifg2@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=szudin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] test: temporary disable sql-tap/collation_unicode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox