From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v1 1/1] vinyl: fix invalid tuple in surrogate delete
Date: Tue, 2 Apr 2019 20:09:54 +0300 [thread overview]
Message-ID: <20190402170953.th6dajfy5etqjztb@esperanza> (raw)
In-Reply-To: <18ddbffc8d63755281e4d4a8366adcded58da720.1554202702.git.kshcherbatov@tarantool.org>
On Tue, Apr 02, 2019 at 01:59:11PM +0300, Kirill Shcherbatov wrote:
> If the map contains non-string keys that cannot be used in the
> JSON index, an incorrect tuple is created in
> vy_stmt_new_surrogate_delete_raw during the construction of the
> surrogate tuple. This occurs because the number of items that
> the map contains has already been copied, while such invalid
> key-value pairs are not copied.
> The poblem is resolved through the creation of dummy nil:nil
> pairs in such cases.
> ---
> https://github.com/tarantool/tarantool/tree/kshch/surrogate-delete-raw-fixup
>
> src/box/vy_stmt.c | 3 +++
> test/engine/json.result | 22 ++++++++++++++++++++++
> test/engine/json.test.lua | 9 +++++++++
> 3 files changed, 34 insertions(+)
Pushed to master, thanks.
prev parent reply other threads:[~2019-04-02 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 10:59 Kirill Shcherbatov
2019-04-02 17:09 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402170953.th6dajfy5etqjztb@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v1 1/1] vinyl: fix invalid tuple in surrogate delete' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox