Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kyukhin@tarantool.org, Mergen Imeev <imeevma@gmail.com>
Subject: [tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()
Date: Tue, 2 Apr 2019 11:55:02 +0300	[thread overview]
Message-ID: <20190402085502.GO25072@chai> (raw)
In-Reply-To: <c6d412b8-e95b-d39d-fa96-023df31ef3fb@tarantool.org>

* Imeev Mergen <imeevma@tarantool.org> [19/04/02 11:34]:

Sure.

> On 4/2/19 11:21 AM, Konstantin Osipov wrote:
> > * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/01 23:03]:
> > > +		luaL_pushuint64(L, db->nChange);
> > > +		lua_setfield(L, -2, "rowcount");
> > Another small nit is about this name. We write
> > IPROTO_SQL_ROW_COUNT as a key name, but rowcount (note no
> > underscore) in Lua. I would either use a consistent naming (either
> > with or without underscore), or, better yet, find a name which
> > doesn't provoke confusion.
> > Considering we use autoincrement_ids (notice absence of space
> > after auto), I'd call the member row_count.
> > 
> > 
> Do you mind if I do this as follow up separate patch? Also I plan
> to use sql_info_key_strs in netbox_decode_sql_info() and
> port_sql_dump_lua() for this.
> 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-04-02  8:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 19:59 [tarantool-patches] [PATCH v10 0/4] box.sql.execute removal Vladislav Shpilevoy
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 1/4] iproto: create port_sql Vladislav Shpilevoy
2019-04-02  8:01   ` [tarantool-patches] " Konstantin Osipov
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 2/4] sql: export sql_bind structure and API Vladislav Shpilevoy
2019-04-02  8:03   ` [tarantool-patches] " Konstantin Osipov
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 3/4] sql: create box.execute() Vladislav Shpilevoy
2019-04-02  8:13   ` [tarantool-patches] " Konstantin Osipov
2019-04-02  8:28     ` Vladislav Shpilevoy
2019-04-02  9:22       ` Konstantin Osipov
2019-04-02  9:33         ` Vladislav Shpilevoy
2019-04-02  9:45           ` Vladislav Shpilevoy
2019-04-02  8:21   ` Konstantin Osipov
2019-04-02  8:34     ` Imeev Mergen
2019-04-02  8:55       ` Konstantin Osipov [this message]
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 4/4] sql: remove box.sql.execute() Vladislav Shpilevoy
2019-04-02  8:19   ` [tarantool-patches] " Konstantin Osipov
2019-04-01 20:02 ` [tarantool-patches] Re: [PATCH v10 0/4] box.sql.execute removal Vladislav Shpilevoy
2019-04-03  7:56 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402085502.GO25072@chai \
    --to=kostja@tarantool.org \
    --cc=imeevma@gmail.com \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox