From: Konstantin Osipov <kostja@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size
Date: Tue, 2 Apr 2019 10:14:11 +0300 [thread overview]
Message-ID: <20190402071411.GA25072@chai> (raw)
In-Reply-To: <20190401220516.GF2431@uranus.lan>
* Cyrill Gorcunov <gorcunov@gmail.com> [19/04/02 01:09]:
> > I don't think we should bother with making sure the stack is right
> > for all fibers. You set the stack size, then you start fibers
> > which depend on it.
>
> Kostja, "require('fiber').cfg{stack_size=value})" implies that
> lua read and parse it, but lua *itself* runs inside a fiber where
> we've the stack size already allocated and what is worse its size
> is compiled in. Next time when "readline" developers increase *own*
> stack size we hit the same bug. Users simply won't have a chance to
> run tarantool, instead they will have to wait us to increase default
> stack size and rebuild the program.
Yes. We could remedy this by making the first (REPL or script)
fiber stack sufficiently large at once.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-04-02 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:38 [RFC 0/2] lib/core/fiber: Allow to extend stack size via env variable Cyrill Gorcunov
2019-03-19 19:38 ` [PATCH 1/2] lib/core/fiber: Rename stack_direction to stack_growsdown Cyrill Gorcunov
2019-03-27 9:35 ` Vladimir Davydov
2019-03-27 9:48 ` Cyrill Gorcunov
2019-03-27 10:20 ` Vladimir Davydov
2019-03-27 10:30 ` Cyrill Gorcunov
2019-03-19 19:38 ` [PATCH 2/2] lib/core/fiber: Allow to extend default stack size Cyrill Gorcunov
2019-03-27 9:35 ` Vladimir Davydov
2019-03-27 9:46 ` Cyrill Gorcunov
2019-03-27 10:15 ` Vladimir Davydov
2019-03-27 10:23 ` Cyrill Gorcunov
2019-04-01 17:41 ` Cyrill Gorcunov
2019-04-01 18:58 ` Konstantin Osipov
2019-04-01 19:19 ` Cyrill Gorcunov
2019-04-01 20:51 ` Konstantin Osipov
2019-04-01 22:05 ` Cyrill Gorcunov
2019-04-02 7:14 ` Konstantin Osipov [this message]
2019-04-02 8:09 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402071411.GA25072@chai \
--to=kostja@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox