Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size
Date: Mon, 1 Apr 2019 22:19:09 +0300	[thread overview]
Message-ID: <20190401191909.GE2431@uranus.lan> (raw)
In-Reply-To: <20190401185845.GA21609@chai>

On Mon, Apr 01, 2019 at 09:58:45PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [19/04/01 20:44]:
> 
> require('fiber').cfg{stack_size=value})

Wait, at such early stage we don't have lua initialized yet.
Letme describe the issue again, I think it might lost in threads:
I would like to provide user a way to configure default stack
size so we won't have to recompile tarantool to increase stack
sizes in future.

I assume we can stick to the idea that every fiber in the
system should have same stack size for simplicity sake.
Since we need known stack size at the early bootstrap stage
(for main_cord, even earlier than we initialize lua) we can't
use traditional cfg engine. Instead we either should use
environment variables, either some configuration file.

Or I miss something obvious?

  reply	other threads:[~2019-04-01 19:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 19:38 [RFC 0/2] lib/core/fiber: Allow to extend stack size via env variable Cyrill Gorcunov
2019-03-19 19:38 ` [PATCH 1/2] lib/core/fiber: Rename stack_direction to stack_growsdown Cyrill Gorcunov
2019-03-27  9:35   ` Vladimir Davydov
2019-03-27  9:48     ` Cyrill Gorcunov
2019-03-27 10:20       ` Vladimir Davydov
2019-03-27 10:30         ` Cyrill Gorcunov
2019-03-19 19:38 ` [PATCH 2/2] lib/core/fiber: Allow to extend default stack size Cyrill Gorcunov
2019-03-27  9:35   ` Vladimir Davydov
2019-03-27  9:46     ` Cyrill Gorcunov
2019-03-27 10:15       ` Vladimir Davydov
2019-03-27 10:23         ` Cyrill Gorcunov
2019-04-01 17:41           ` Cyrill Gorcunov
2019-04-01 18:58             ` Konstantin Osipov
2019-04-01 19:19               ` Cyrill Gorcunov [this message]
2019-04-01 20:51                 ` Konstantin Osipov
2019-04-01 22:05                   ` Cyrill Gorcunov
2019-04-02  7:14                     ` Konstantin Osipov
2019-04-02  8:09                       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401191909.GE2431@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox