* [tarantool-patches] [PATCH] sql: fix flaky collation test
@ 2019-03-29 9:47 Ivan Koptelov
2019-04-01 14:21 ` [tarantool-patches] " Kirill Yukhin
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Koptelov @ 2019-03-29 9:47 UTC (permalink / raw)
To: tarantool-patches, kyukhin; +Cc: Ivan Koptelov
Sometimes this test failed because collation 'c' was not dropped
automatically. Now it is always dropped manually, so the problem
is no more.
---
Branch : https://github.com/tarantool/tarantool/tree/sudobobo/fix-flaky-collation-test
Issue : None
test/sql/collation.result | 3 +++
test/sql/collation.test.lua | 1 +
2 files changed, 4 insertions(+)
diff --git a/test/sql/collation.result b/test/sql/collation.result
index 90a9f728c..527c431e5 100644
--- a/test/sql/collation.result
+++ b/test/sql/collation.result
@@ -796,3 +796,6 @@ box.space._collation.index.name:get({'c'})
---
- [4, 'c', 1, 'ICU', 'unicode', {'strength': 'tertiary'}]
...
+box.internal.collation.drop('c')
+---
+...
diff --git a/test/sql/collation.test.lua b/test/sql/collation.test.lua
index 9549cf237..a83cb26d7 100644
--- a/test/sql/collation.test.lua
+++ b/test/sql/collation.test.lua
@@ -313,3 +313,4 @@ box.space.JJ:drop()
--
box.internal.collation.create('c', 'ICU', 'unicode')
box.space._collation.index.name:get({'c'})
+box.internal.collation.drop('c')
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tarantool-patches] Re: [PATCH] sql: fix flaky collation test
2019-03-29 9:47 [tarantool-patches] [PATCH] sql: fix flaky collation test Ivan Koptelov
@ 2019-04-01 14:21 ` Kirill Yukhin
0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2019-04-01 14:21 UTC (permalink / raw)
To: Ivan Koptelov; +Cc: tarantool-patches
Hello,
On 29 Mar 12:47, Ivan Koptelov wrote:
> Sometimes this test failed because collation 'c' was not dropped
> automatically. Now it is always dropped manually, so the problem
> is no more.
> ---
> Branch : https://github.com/tarantool/tarantool/tree/sudobobo/fix-flaky-collation-test
> Issue : None
I've checked your patch into master and 2.1 branch.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-01 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 9:47 [tarantool-patches] [PATCH] sql: fix flaky collation test Ivan Koptelov
2019-04-01 14:21 ` [tarantool-patches] " Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox