Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 1/3] vinyl: make tx_manager_abort_writers_for_ddl more thorough
Date: Thu, 28 Mar 2019 20:28:57 +0300	[thread overview]
Message-ID: <20190328172857.GH11518@chai> (raw)
In-Reply-To: <20190328160337.zpne4bckh7cxxkb2@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/28 19:16]:
> On Thu, Mar 28, 2019 at 06:52:27PM +0300, Vladimir Davydov wrote:
> > diff --git a/src/box/vinyl.c b/src/box/vinyl.c
> > index 3ef43e18..24f900cb 100644
> > --- a/src/box/vinyl.c
> > +++ b/src/box/vinyl.c
> > @@ -2433,8 +2433,10 @@ vinyl_engine_begin_statement(struct engine *engine, struct txn *txn)
> >  	(void)engine;
> >  	struct vy_tx *tx = txn->engine_tx;
> >  	struct txn_stmt *stmt = txn_current_stmt(txn);
> > +	struct index *pk = space_index(stmt->space, 0);
> >  	assert(tx != NULL);
> > -	return vy_tx_begin_statement(tx, &stmt->engine_savepoint);
> > +	return vy_tx_begin_statement(tx, pk != NULL ? vy_lsm(pk) : NULL,
> > +				     &stmt->engine_savepoint);
> 
> Argh. On the second thought, this looks kinda ugly. I'll use space ptr
> instead as you suggested initiallly, so that you can take your pick.
> Stay tuned for v3.

Both patches are OK, I don't see much difference, please push
whichever you like more.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-03-28 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 15:52 [PATCH v2 0/3] Fix DML vs DDL race Vladimir Davydov
2019-03-28 15:52 ` [PATCH v2 1/3] vinyl: make tx_manager_abort_writers_for_ddl more thorough Vladimir Davydov
2019-03-28 16:03   ` Vladimir Davydov
2019-03-28 17:28     ` Konstantin Osipov [this message]
2019-03-28 15:52 ` [PATCH v2 2/3] vinyl: abort affected transactions when space is removed from cache Vladimir Davydov
2019-03-28 15:52 ` [PATCH v2 3/3] Revert "test: skip ddl test for vinyl on travis" Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328172857.GH11518@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 1/3] vinyl: make tx_manager_abort_writers_for_ddl more thorough' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox