From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BF9DD2A6DF for ; Thu, 28 Mar 2019 13:29:00 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XeMnDCY1ewit for ; Thu, 28 Mar 2019 13:29:00 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DC14229FE9 for ; Thu, 28 Mar 2019 13:28:59 -0400 (EDT) Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1h9Ypl-00037I-RH for tarantool-patches@freelists.org; Thu, 28 Mar 2019 20:28:58 +0300 Date: Thu, 28 Mar 2019 20:28:57 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 1/3] vinyl: make tx_manager_abort_writers_for_ddl more thorough Message-ID: <20190328172857.GH11518@chai> References: <1574fba56e436ce5129fc0a2853afb3f8c946279.1553787937.git.vdavydov.dev@gmail.com> <20190328160337.zpne4bckh7cxxkb2@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328160337.zpne4bckh7cxxkb2@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/03/28 19:16]: > On Thu, Mar 28, 2019 at 06:52:27PM +0300, Vladimir Davydov wrote: > > diff --git a/src/box/vinyl.c b/src/box/vinyl.c > > index 3ef43e18..24f900cb 100644 > > --- a/src/box/vinyl.c > > +++ b/src/box/vinyl.c > > @@ -2433,8 +2433,10 @@ vinyl_engine_begin_statement(struct engine *engine, struct txn *txn) > > (void)engine; > > struct vy_tx *tx = txn->engine_tx; > > struct txn_stmt *stmt = txn_current_stmt(txn); > > + struct index *pk = space_index(stmt->space, 0); > > assert(tx != NULL); > > - return vy_tx_begin_statement(tx, &stmt->engine_savepoint); > > + return vy_tx_begin_statement(tx, pk != NULL ? vy_lsm(pk) : NULL, > > + &stmt->engine_savepoint); > > Argh. On the second thought, this looks kinda ugly. I'll use space ptr > instead as you suggested initiallly, so that you can take your pick. > Stay tuned for v3. Both patches are OK, I don't see much difference, please push whichever you like more. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov