Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 5/6] vinyl: run iterator: refactor seek method
Date: Thu, 28 Mar 2019 17:58:19 +0300	[thread overview]
Message-ID: <20190328145819.rovnk4txkhfziiec@esperanza> (raw)
In-Reply-To: <20190328143947.GE23295@chai>

On Thu, Mar 28, 2019 at 05:39:47PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/26 18:56]:
> > A few changes to make the function more straightforward:
> > 
> >  - Move bloom checking and LSN filtering out of 'do_seek' helper. Make
> >    the helper do just one simple task - lookup the first one in a series
> >    of statements matching the given search criteria.
> >  - Fold iterator type and key substitution in 'seek' method, similarly
> >    to how we did it for other iterators.
> >  - Cleanup EQ checks. Use the original iterator type and key where
> >    appropriate to remove extra checks in calling methods. Don't check EQ
> >    in 'seek' method in case it was checked by 'do_seek'.
> >  - Add some comments.
> 
> LGTM (same comment re passing EOF in return value applies).
> eq_found looks cumbersome, perhaps you could both kill bool
> eq_found and not pass eof in the out parameter of do_seek()?

eq_found is an optimization that allows us to save a tuple comparison.
Not that it really matters for the disk iterator, but still I'd rather
keep it.

As I said, I agree that retval conventions look ugly in the iterator
code. I didn't plan on cleaning it up now, because it doesn't really
stand in the way of tuple hints. I'll look into it a bit later.

  reply	other threads:[~2019-03-28 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 15:50 [PATCH 0/6] vinyl: iterator cleanup Vladimir Davydov
2019-03-26 15:50 ` [PATCH 1/6] vinyl: txw iterator: fold eq check in seek method Vladimir Davydov
2019-03-28 14:25   ` [tarantool-patches] " Konstantin Osipov
2019-03-26 15:50 ` [PATCH 2/6] vinyl: cache " Vladimir Davydov
2019-03-28 14:27   ` [tarantool-patches] " Konstantin Osipov
2019-03-26 15:50 ` [PATCH 3/6] vinyl: cache iterator: consolidate curr_stmt updates Vladimir Davydov
2019-03-28 14:29   ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:47     ` Vladimir Davydov
2019-03-26 15:50 ` [PATCH 4/6] vinyl: run iterator: zap search_ended flag Vladimir Davydov
2019-03-28 14:35   ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:50     ` Vladimir Davydov
2019-03-26 15:50 ` [PATCH 5/6] vinyl: run iterator: refactor seek method Vladimir Davydov
2019-03-28 14:39   ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:58     ` Vladimir Davydov [this message]
2019-03-26 15:50 ` [PATCH 6/6] vinyl: simplify read iterator restoration behavior Vladimir Davydov
2019-03-28 14:47   ` [tarantool-patches] " Konstantin Osipov
2019-03-28 16:28 ` [PATCH 0/6] vinyl: iterator cleanup Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328145819.rovnk4txkhfziiec@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] Re: [PATCH 5/6] vinyl: run iterator: refactor seek method' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox