From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 4/6] vinyl: run iterator: zap search_ended flag
Date: Thu, 28 Mar 2019 17:50:40 +0300 [thread overview]
Message-ID: <20190328145040.wuq2b26bhkoyub4l@esperanza> (raw)
In-Reply-To: <20190328143518.GD23295@chai>
On Thu, Mar 28, 2019 at 05:35:18PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/26 18:56]:
> > It's equivalent to (itr->search_started && itr->curr_stmt == NULL).
>
> OK to push, but same as in the previous patch, I would not use the
> return value for anything but success/error. We already have a
> boolean parameter 'equal found', we could turn it into a enum,
> since 'equal found' and 'eof' are mutually exclusive.
Returning 1 is consistent with vy_mem_iterator behavior. Other
vy_run_iterator functions stick to this convention, too. Yeah,
it looks rather awkward, but I think we'd better clean it up in
a separate patch. I'll look what we can do about it.
next prev parent reply other threads:[~2019-03-28 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:50 [PATCH 0/6] vinyl: iterator cleanup Vladimir Davydov
2019-03-26 15:50 ` [PATCH 1/6] vinyl: txw iterator: fold eq check in seek method Vladimir Davydov
2019-03-28 14:25 ` [tarantool-patches] " Konstantin Osipov
2019-03-26 15:50 ` [PATCH 2/6] vinyl: cache " Vladimir Davydov
2019-03-28 14:27 ` [tarantool-patches] " Konstantin Osipov
2019-03-26 15:50 ` [PATCH 3/6] vinyl: cache iterator: consolidate curr_stmt updates Vladimir Davydov
2019-03-28 14:29 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:47 ` Vladimir Davydov
2019-03-26 15:50 ` [PATCH 4/6] vinyl: run iterator: zap search_ended flag Vladimir Davydov
2019-03-28 14:35 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:50 ` Vladimir Davydov [this message]
2019-03-26 15:50 ` [PATCH 5/6] vinyl: run iterator: refactor seek method Vladimir Davydov
2019-03-28 14:39 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:58 ` Vladimir Davydov
2019-03-26 15:50 ` [PATCH 6/6] vinyl: simplify read iterator restoration behavior Vladimir Davydov
2019-03-28 14:47 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 16:28 ` [PATCH 0/6] vinyl: iterator cleanup Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328145040.wuq2b26bhkoyub4l@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH 4/6] vinyl: run iterator: zap search_ended flag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox