From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 2/2] vinyl: fail aborted transactions early
Date: Thu, 28 Mar 2019 17:43:00 +0300 [thread overview]
Message-ID: <20190328144300.gzod7r5b2t75epht@esperanza> (raw)
In-Reply-To: <20190328140557.GC11518@chai>
On Thu, Mar 28, 2019 at 05:05:57PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/22 21:17]:
> > We abort transactions when switching to read-only mode, building a new
> > index, or reverting a statement after a failed WAL write. It's no use
> > to allow an aborted transaction to proceed as usual until commit - we
> > should fail it as early as we can to avoid wasting resources. Currently,
> > we do it in a rather abrupt way - by an assertion :-) This patch makes
> > any DML/DQL operation fail gracefully instead.
> > Closes #4070
>
> OK to push.
Pushed both patches to master, 2.1, and 1.10.
next prev parent reply other threads:[~2019-03-28 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 18:12 [PATCH 1/2] vinyl: drop useless vy_read_view->is_aborted flag Vladimir Davydov
2019-03-22 18:12 ` [PATCH 2/2] vinyl: fail aborted transactions early Vladimir Davydov
2019-03-28 14:05 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:43 ` Vladimir Davydov [this message]
2019-03-28 12:50 ` [tarantool-patches] Re: [PATCH 1/2] vinyl: drop useless vy_read_view->is_aborted flag Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328144300.gzod7r5b2t75epht@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH 2/2] vinyl: fail aborted transactions early' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox