Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Georgy Kirichenko <georgy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 2/5] Synchronize lua schema update with space cache
Date: Wed, 27 Mar 2019 14:45:56 +0300	[thread overview]
Message-ID: <20190327114556.GB10430@chai> (raw)
In-Reply-To: <20190327103229.4mfg6ptmqiz4vdub@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/27 14:22]:
> commit 1f736583361f537c8e1fb4ea0df0b92ee8d50c6d
> Author: Vladimir Davydov <vdavydov.dev@gmail.com>
> Date:   Tue Sep 19 14:21:59 2017 +0300
> 
>     box: use trigger to push space data to Lua
> 
>     Currently, it is done by space_cache_replace/delete which violates
>     incapsulation. Let's introduce a trigger that is fired after a change in
>     a space definition is committed and use it to propagate changes to Lua.
>     Patch by @kostja.

Let's call triggers, but call them directly from
space_cache_replace(). Please submit a follow up patch. We
discussed this with Georgy, but decided it's a bit outside of the
scope of the current patch.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-03-27 11:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 12:06 [tarantool-patches] [PATCH v3 0/5] Transaction in replication protocol Georgy Kirichenko
2019-03-22 12:06 ` [tarantool-patches] [PATCH v3 1/5] Abort vinyl index creation in case of truncation rollback Georgy Kirichenko
2019-03-27  9:59   ` Vladimir Davydov
2019-03-22 12:06 ` [tarantool-patches] [PATCH v3 2/5] Synchronize lua schema update with space cache Georgy Kirichenko
2019-03-27 10:03   ` Vladimir Davydov
2019-03-27 10:32     ` Vladimir Davydov
2019-03-27 11:45       ` Konstantin Osipov [this message]
2019-03-22 12:06 ` [tarantool-patches] [PATCH v3 3/5] Require for single statement not autocommit in case of ddl Georgy Kirichenko
2019-03-27 10:49   ` Vladimir Davydov
2019-03-22 12:06 ` [tarantool-patches] [PATCH v3 4/5] Transaction support for applier Georgy Kirichenko
2019-03-27 11:41   ` Vladimir Davydov
2019-03-27 11:48   ` Vladimir Davydov
2019-03-22 12:06 ` [tarantool-patches] [PATCH v3 5/5] Raise an error if remote transaction produces non-local changes Georgy Kirichenko
2019-03-27 12:06   ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327114556.GB10430@chai \
    --to=kostja@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v3 2/5] Synchronize lua schema update with space cache' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox