Re: [PATCH 2/2] lib/core/fiber: Allow to extend default stack size

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Wed, Mar 27, 2019 at 01:15:52PM +0300, Vladimir Davydov wrote:
...
> > 
> > These are not constants anymore since we're to ajust the values.
> 
> Ah, I see. Anyway, I'd leave the constants alone and instead introduce a
> separate static variable to store the current stack size in, because
> mixing constants (min_size, watermark) and variables (current_default)
> in one array doesn't look good to me.

From my POV using array and indices is more elegant than spreading
variables but I won't insist :)
...
> > 
> > Yes, stacks are allocated earlier, and we simply can't adjust already
> > allocated stack thus we might need to distinguish stack sizes between
> > cord_main and new fibers. This gonna be hard and I would like to escape
> > such complexity. Seriously, we should use a hard rule: every stack in
> > the engine has the same size allocated.
> > 
> > Lets think -- is there a chance we will have to provide more configurable
> > settings for early init stage in future? If yes then we should invent
> > early init stage for lua (or say some json fine in /etc). If no and
> > there is no chance we might need something else in future, better to
> > stick with simplier solution as environment variables.
> 
> Makes sense. But as this is a change in the API, we should consult
> Kostja (Cc-ed).

Yes, thanks for CC'ing. I managed to forgot to cc him in first place.