From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: "Георгий Кириченко" <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
Subject: Re: [tarantool-patches] [PATCH 2/4] vinyl: don't abort transactions that modify only local spaces for ro
Date: Mon, 25 Mar 2019 12:30:02 +0300 [thread overview]
Message-ID: <20190325093002.zpu6d5mlrabfyu7g@esperanza> (raw)
In-Reply-To: <4105454.y3sHZnr1ha@home.lan>
On Mon, Mar 25, 2019 at 11:58:18AM +0300, Георгий Кириченко wrote:
> On Monday, March 25, 2019 11:13:51 AM MSK Vladimir Davydov wrote:
> > On Mon, Mar 25, 2019 at 08:27:28AM +0300, Георгий Кириченко wrote:
> > > I think it is out of scope of the task.
> >
> > So what? This was a known issue when the switch_to_ro was introduced.
> > Better fix it now than never, especially counting the fact that it's
> > a low hanging fruit after patch 1.
> So let it be in a separate patch with assigned ticket.
Why? It depends on the previous patch.
I ask to move a patch out of a series only if there's a great chance to
commit it before the rest of the series.
Filing a ticket when the patch is ready looks like excessive
bureaucracy to me. In fact, it's just a follow-up for #4016.
next prev parent reply other threads:[~2019-03-25 9:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 21:07 [PATCH 0/4] Fix DML vs DDL race Vladimir Davydov
2019-03-23 21:07 ` [PATCH 1/4] vinyl: introduce hash of spaces affected by transaction Vladimir Davydov
2019-03-28 13:25 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 13:58 ` Vladimir Davydov
2019-03-23 21:07 ` [PATCH 2/4] vinyl: don't abort transactions that modify only local spaces for ro Vladimir Davydov
2019-03-25 5:27 ` [tarantool-patches] " Георгий Кириченко
2019-03-25 8:13 ` Vladimir Davydov
2019-03-25 8:58 ` Георгий Кириченко
2019-03-25 9:30 ` Vladimir Davydov [this message]
2019-03-23 21:07 ` [PATCH 3/4] vinyl: abort affected transactions when space is removed from cache Vladimir Davydov
2019-03-25 5:26 ` [tarantool-patches] " Георгий Кириченко
2019-03-25 8:17 ` Vladimir Davydov
[not found] ` <1564677.EMV258VVK2@home.lan>
2019-03-25 9:51 ` Vladimir Davydov
2019-03-25 5:45 ` Георгий Кириченко
2019-03-25 8:21 ` Vladimir Davydov
2019-03-25 9:03 ` Георгий Кириченко
2019-03-28 13:45 ` [tarantool-patches] " Konstantin Osipov
2019-03-28 14:02 ` Vladimir Davydov
2019-03-28 14:12 ` Konstantin Osipov
2019-03-23 21:07 ` [PATCH 4/4] Revert "test: skip ddl test for vinyl on travis" Vladimir Davydov
2019-03-28 13:46 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325093002.zpu6d5mlrabfyu7g@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 2/4] vinyl: don'\''t abort transactions that modify only local spaces for ro' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox