From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: fix format of tuple produced with frommap()
Date: Thu, 21 Mar 2019 18:41:20 +0300 [thread overview]
Message-ID: <20190321154120.lq4d6srux22q46f4@tarantool.org> (raw)
In-Reply-To: <558c48af114ba67b997489ce2a150ffa1b7f5a22.1553088664.git.kshcherbatov@tarantool.org>
Hello,
On 20 Mar 16:31, Kirill Shcherbatov wrote:
> Previously, all tuples created with frommap() used default format
> table_format_runtime, and therefore the created data tuples were
> not checked for the ability to be inserted into the target space.
>
> Moreover frommap(...):tomap(...) procedures sequence also did not
> work because tomap(..) routine assumes that the tuple has format
> with field names.
>
> Closes #4045
>
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-4045-frommap-tuple-format-fix
> Issue: https://github.com/tarantool/tarantool/issues/4045
I've checked yout patch into master, 2.1 and 1.10 branches.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-03-21 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 13:31 [tarantool-patches] " Kirill Shcherbatov
2019-03-21 13:36 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-21 15:41 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321154120.lq4d6srux22q46f4@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] box: fix format of tuple produced with frommap()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox