Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 2/2] build: set specific name for packages of master branch
Date: Thu, 21 Mar 2019 17:21:54 +0300	[thread overview]
Message-ID: <20190321142154.GA6858@chai> (raw)
In-Reply-To: <20190321140955.ll26wtga63p47hve@tarantool.org>

* Kirill Yukhin <kyukhin@tarantool.org> [19/03/21 17:14]:
>  tarantool --version
> -Tarantool 2.minor.patch-<rev>-<commit>
> +Tarantool 9999.minor.patch-<rev>-<commit>

Replication looks at this number when it checks compatibility of
slave and master. It will break after this change - get confused
by a too large master number running in production.

Schema versioning is also looking at this number and schema
upgrade executes only if the current tarantool schema version is
smaller than the binary version. It is not looking at the number
explicitly, but still.

I'm almost certain many modules look at this number to check
server capabilities and compatibility.

By making this change you effectively rendered the master branch
unusable to the community.

There is not a single reason for this decision except "others are
doing it this way".

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-03-21 14:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 13:25 [tarantool-patches] [PATCH 0/2] build: update rules for " Kirill Yukhin
2019-03-21 13:25 ` [tarantool-patches] [PATCH 1/2] build: update rules for extended CI Kirill Yukhin
2019-03-22  0:44   ` [tarantool-patches] " Alexander Turenko
2019-03-22  8:41   ` Kirill Yukhin
2019-03-22 11:51     ` Alexander Turenko
2019-03-22 15:22       ` Kirill Yukhin
2019-03-22 15:36         ` Alexander Turenko
2019-03-21 13:25 ` [tarantool-patches] [PATCH 2/2] build: set specific name for packages of master branch Kirill Yukhin
2019-03-21 14:09   ` [tarantool-patches] " Kirill Yukhin
2019-03-21 14:21     ` Konstantin Osipov [this message]
2019-03-21 15:20       ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321142154.GA6858@chai \
    --to=kostja@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] build: set specific name for packages of master branch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox