From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: bind BLOB value as BLOB not as STRING
Date: Tue, 19 Mar 2019 16:21:31 +0300 [thread overview]
Message-ID: <20190319132131.nwkm57rpi7x5udhd@tarantool.org> (raw)
In-Reply-To: <20190318010558.15883-1-korablev@tarantool.org>
Hello,
On 18 Mar 04:05, Nikita Pettik wrote:
> It is obvious that BLOB (that is value encoded in msgpack with MP_BIN
> format) values must be bound as BLOBs, not as strings. Unfortunately,
> they were bound as strings, which lead to wrong resulting type
> calculations after execution of SQL statement.
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/blob-type-binding-fix
I've checked your patch into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-03-19 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 1:05 [tarantool-patches] " Nikita Pettik
2019-03-18 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-19 13:21 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319132131.nwkm57rpi7x5udhd@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] sql: bind BLOB value as BLOB not as STRING' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox