From: Kirill Yukhin <kyukhin@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] lua: remove digest.sha() and digest.sha_hex()
Date: Tue, 19 Mar 2019 14:39:49 +0300 [thread overview]
Message-ID: <20190319113948.ftr7iqa2frw33whm@tarantool.org> (raw)
In-Reply-To: <6c81abf4ab1cca5f599153553a1b28f3fac89115.1552949246.git.alexander.turenko@tarantool.org>
Hello,
On 19 Mar 01:49, Alexander Turenko wrote:
> SHA-0 is considered weak for years and was removed in OpenSSL since
> 1.1.0.
>
> These Lua functions did not work since 15ed10e4, but give 'Digest
> method "sha" is not supported' error for any input. Removed them to
> don't confuse a user with a Tab completion.
>
> Follow up #1722.
> Fixes #4028.
> ---
>
> issue: https://github.com/tarantool/tarantool/issues/4028
> branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-4028-remove-digest-sha-0
I've checked your patch into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-03-19 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 22:49 [tarantool-patches] " Alexander Turenko
2019-03-19 11:39 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319113948.ftr7iqa2frw33whm@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] lua: remove digest.sha() and digest.sha_hex()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox