Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate
Date: Tue, 19 Mar 2019 00:19:19 +0300	[thread overview]
Message-ID: <20190318211919.GB13557@chai> (raw)
In-Reply-To: <20190318191746.GE2469@uranus.lan>

* Cyrill Gorcunov <gorcunov@gmail.com> [19/03/18 22:20]:
> On Mon, Mar 18, 2019 at 10:10:08PM +0300, Konstantin Osipov wrote:
> > > 
> > > Even 8 elements are not guarantee us from false positives and
> > > with a sole element the situation would be even worse.
> > 
> > Well, then let's increase the number of elements to 32 or 64, or,
> > better yet, 128, to make the situation better.
> > 
> > Why did you guys choose 8?
> 
> To cover low 1024 bytes. Maximal path is about 4K limit
> so I think in average ~1/4 of page should catch paths
> on stack.

Okay, well, that at least a plausible cause, I guess I'd be nice to
see it in the comment for the poison array. However, you could use
4 integers and a larger poison offset?-))

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-03-18 21:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 17:23 Cyrill Gorcunov
2019-03-18 17:52 ` Vladimir Davydov
2019-03-18 18:07   ` Cyrill Gorcunov
2019-03-18 18:55   ` [tarantool-patches] " Konstantin Osipov
2019-03-18 19:04     ` Cyrill Gorcunov
2019-03-18 19:10       ` Konstantin Osipov
2019-03-18 19:17         ` Cyrill Gorcunov
2019-03-18 21:19           ` Konstantin Osipov [this message]
2019-03-18 21:38             ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318211919.GB13557@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox