From: Konstantin Osipov <kostja@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: vdavydov.dev@gmail.com, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate
Date: Mon, 18 Mar 2019 22:10:08 +0300 [thread overview]
Message-ID: <20190318191008.GA13557@chai> (raw)
In-Reply-To: <20190318190446.GD2469@uranus.lan>
* Cyrill Gorcunov <gorcunov@gmail.com> [19/03/18 22:07]:
> On Mon, Mar 18, 2019 at 09:55:29PM +0300, Konstantin Osipov wrote:
> > * Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/18 20:56]:
> >
> > > On Mon, Mar 18, 2019 at 08:23:52PM +0300, Cyrill Gorcunov wrote:
> > > > The stack_watermark member declared with HAVE_MADV_DONTNEED wrap,
> > > > so need to guard it here the same way.
> >
> > What is the reason to keep the poison pool 8 elements now that it
> > is only used to save on madvise() invocations and is put in a
> > random position? Shouldn't 1 element be enough?
>
> Even 8 elements are not guarantee us from false positives and
> with a sole element the situation would be even worse.
Well, then let's increase the number of elements to 32 or 64, or,
better yet, 128, to make the situation better.
Why did you guys choose 8?
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-03-18 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:23 Cyrill Gorcunov
2019-03-18 17:52 ` Vladimir Davydov
2019-03-18 18:07 ` Cyrill Gorcunov
2019-03-18 18:55 ` [tarantool-patches] " Konstantin Osipov
2019-03-18 19:04 ` Cyrill Gorcunov
2019-03-18 19:10 ` Konstantin Osipov [this message]
2019-03-18 19:17 ` Cyrill Gorcunov
2019-03-18 21:19 ` Konstantin Osipov
2019-03-18 21:38 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318191008.GA13557@chai \
--to=kostja@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox