From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate
Date: Mon, 18 Mar 2019 22:04:46 +0300 [thread overview]
Message-ID: <20190318190446.GD2469@uranus.lan> (raw)
In-Reply-To: <20190318185529.GA11507@chai>
On Mon, Mar 18, 2019 at 09:55:29PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/18 20:56]:
>
> > On Mon, Mar 18, 2019 at 08:23:52PM +0300, Cyrill Gorcunov wrote:
> > > The stack_watermark member declared with HAVE_MADV_DONTNEED wrap,
> > > so need to guard it here the same way.
>
> What is the reason to keep the poison pool 8 elements now that it
> is only used to save on madvise() invocations and is put in a
> random position? Shouldn't 1 element be enough?
Even 8 elements are not guarantee us from false positives and
with a sole element the situation would be even worse.
> What is the actual stack size for 99.9% of cases? Why not put the
> poison at 16kb of stack?
Well, I think we can't answer this question without gathering
statistics.
next prev parent reply other threads:[~2019-03-18 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:23 Cyrill Gorcunov
2019-03-18 17:52 ` Vladimir Davydov
2019-03-18 18:07 ` Cyrill Gorcunov
2019-03-18 18:55 ` [tarantool-patches] " Konstantin Osipov
2019-03-18 19:04 ` Cyrill Gorcunov [this message]
2019-03-18 19:10 ` Konstantin Osipov
2019-03-18 19:17 ` Cyrill Gorcunov
2019-03-18 21:19 ` Konstantin Osipov
2019-03-18 21:38 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318190446.GD2469@uranus.lan \
--to=gorcunov@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox