From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
Subject: Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate
Date: Mon, 18 Mar 2019 20:52:46 +0300 [thread overview]
Message-ID: <20190318175246.22utl4hoc3jnxuk2@esperanza> (raw)
In-Reply-To: <20190318172352.14128-1-gorcunov@gmail.com>
On Mon, Mar 18, 2019 at 08:23:52PM +0300, Cyrill Gorcunov wrote:
> The stack_watermark member declared with HAVE_MADV_DONTNEED wrap,
> so need to guard it here the same way.
Yep, overlooked it, my bad. I also lost fiber_stack_recycle() stub.
Weird, but it did compile on OS X as is. Looks like OS X supports
MADV_DONTNEED after all :)
Applied to 2.1 and 1.10 with fiber_stack_recycle() fix squashed.
Thanks!
>
> Fixes 553dc562342a52cb44d74a7521c9c8bec70c96a5
> ---
> src/lib/core/fiber.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
> index 243a73bf8..b5033a32e 100644
> --- a/src/lib/core/fiber.c
> +++ b/src/lib/core/fiber.c
> @@ -1076,7 +1076,10 @@ cord_create(struct cord *cord, const char *name)
> cord->sched.stack = NULL;
> cord->sched.stack_size = 0;
> #endif
> +
> +#ifdef HAVE_MADV_DONTNEED
> cord->sched.stack_watermark = NULL;
> +#endif
> }
>
> void
next prev parent reply other threads:[~2019-03-18 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:23 Cyrill Gorcunov
2019-03-18 17:52 ` Vladimir Davydov [this message]
2019-03-18 18:07 ` Cyrill Gorcunov
2019-03-18 18:55 ` [tarantool-patches] " Konstantin Osipov
2019-03-18 19:04 ` Cyrill Gorcunov
2019-03-18 19:10 ` Konstantin Osipov
2019-03-18 19:17 ` Cyrill Gorcunov
2019-03-18 21:19 ` Konstantin Osipov
2019-03-18 21:38 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318175246.22utl4hoc3jnxuk2@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] lib/core/fiber: Initialize stack_watermark where appropriate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox