Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [PATCH 1/2] lib/core/fiber: Increase default stack size
Date: Fri, 15 Mar 2019 23:58:01 +0300	[thread overview]
Message-ID: <20190315205802.18847-2-gorcunov@gmail.com> (raw)
In-Reply-To: <20190315205802.18847-1-gorcunov@gmail.com>

The default 64K stack size used for years become too small
for modern distors (Fedora 29 and etc) where third party libraries
(such as ncurses) started to use 64K for own buffers and we get
SIGSGV early without reaching interactive console phase.

Thus we increase default size up to 512K which should fit
for common case. Later we will make this value configurable
to address arbitrary stack sizes without a need to rebuild
the whole code.

Part-of #3418
---
 src/lib/core/fiber.c | 2 +-
 test-run             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
index abd6c6b11..bf2a22bed 100644
--- a/src/lib/core/fiber.c
+++ b/src/lib/core/fiber.c
@@ -95,7 +95,7 @@ enum {
 	/* The minimum allowable fiber stack size in bytes */
 	FIBER_STACK_SIZE_MINIMAL = 16384,
 	/* Default fiber stack size in bytes */
-	FIBER_STACK_SIZE_DEFAULT = 65536
+	FIBER_STACK_SIZE_DEFAULT = 524288
 };
 
 /** Default fiber attributes */
-- 
2.20.1

  reply	other threads:[~2019-03-15 20:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 20:58 [PATCH v6 0/2] " Cyrill Gorcunov
2019-03-15 20:58 ` Cyrill Gorcunov [this message]
2019-03-15 20:58 ` [PATCH 2/2] lib/core/fiber: Relax stack memory usage on recycle Cyrill Gorcunov
2019-03-15 21:12   ` Cyrill Gorcunov
2019-03-18 16:57   ` Vladimir Davydov
2019-03-18 17:06     ` Cyrill Gorcunov
  -- strict thread matches above, loose matches on Subject: below --
2019-03-07 21:31 [PATCH v4 0/2] lib/core/fiber: Increase default stack size Cyrill Gorcunov
2019-03-07 21:31 ` [PATCH 1/2] " Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315205802.18847-2-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 1/2] lib/core/fiber: Increase default stack size' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox