* [PATCH] test: don't leave open read views after vinyl/errinj_tx
@ 2019-03-15 16:43 Vladimir Davydov
2019-03-15 16:43 ` Vladimir Davydov
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Davydov @ 2019-03-15 16:43 UTC (permalink / raw)
To: tarantool-patches
See commit 65061cb4d595 ("test: don't leave open read views after
vinyl/iterator") for more details.
Follow-up #3862
---
test/vinyl/errinj_tx.result | 10 ++++++++++
test/vinyl/errinj_tx.test.lua | 5 +++++
2 files changed, 15 insertions(+)
diff --git a/test/vinyl/errinj_tx.result b/test/vinyl/errinj_tx.result
index a7583b2e..29ec47c8 100644
--- a/test/vinyl/errinj_tx.result
+++ b/test/vinyl/errinj_tx.result
@@ -433,3 +433,13 @@ last_read
space:drop()
---
...
+-- Collect all iterators to make sure no read views are left behind,
+-- as they might disrupt the following test run.
+collectgarbage()
+---
+- 0
+...
+box.stat.vinyl().tx.read_views -- 0
+---
+- 0
+...
diff --git a/test/vinyl/errinj_tx.test.lua b/test/vinyl/errinj_tx.test.lua
index cf83b326..b06831b7 100644
--- a/test/vinyl/errinj_tx.test.lua
+++ b/test/vinyl/errinj_tx.test.lua
@@ -192,3 +192,8 @@ while f2:status() ~= 'dead' do fiber.sleep(0.01) end
last_read
space:drop()
+
+-- Collect all iterators to make sure no read views are left behind,
+-- as they might disrupt the following test run.
+collectgarbage()
+box.stat.vinyl().tx.read_views -- 0
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] test: don't leave open read views after vinyl/errinj_tx
2019-03-15 16:43 [PATCH] test: don't leave open read views after vinyl/errinj_tx Vladimir Davydov
@ 2019-03-15 16:43 ` Vladimir Davydov
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Davydov @ 2019-03-15 16:43 UTC (permalink / raw)
To: tarantool-patches
On Fri, Mar 15, 2019 at 07:43:14PM +0300, Vladimir Davydov wrote:
> See commit 65061cb4d595 ("test: don't leave open read views after
> vinyl/iterator") for more details.
>
> Follow-up #3862
> ---
> test/vinyl/errinj_tx.result | 10 ++++++++++
> test/vinyl/errinj_tx.test.lua | 5 +++++
> 2 files changed, 15 insertions(+)
Trivial. Pushed to 2.1.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-15 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 16:43 [PATCH] test: don't leave open read views after vinyl/errinj_tx Vladimir Davydov
2019-03-15 16:43 ` Vladimir Davydov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox