Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix vinyl/errinj failure
Date: Fri, 15 Mar 2019 19:26:14 +0300	[thread overview]
Message-ID: <20190315162614.d2wh5kbqt7crkmck@esperanza> (raw)
In-Reply-To: <61756ccecf4f99169e945e87e7f72c70ac0f7cc6.1552667136.git.vdavydov.dev@gmail.com>

On Fri, Mar 15, 2019 at 07:25:46PM +0300, Vladimir Davydov wrote:
> The patch fixes the following test failure:
> 
>  | --- vinyl/errinj.result Fri Mar 15 19:19:19 2019
>  | +++ vinyl/errinj.reject Fri Mar 15 19:21:37 2019
>  | @@ -854,7 +854,8 @@
>  |  ...
>  |  ret
>  |  ---
>  | -- - [3, 3]
>  | +- - [2, 2]
>  | +  - [3, 3]
>  |  ...
>  |  s:drop()
>  |  ---
> 
> The error occurrs, because the test doesn't make sure that a read from
> the scondary index actually occurs and the fiber does stall on a read
> from the primary index. Use index stats to assure that.
> 
> Closes #3863
> ---
>  test/vinyl/errinj.result   | 25 +++++++++++++++++++------
>  test/vinyl/errinj.test.lua | 11 +++++++----
>  2 files changed, 26 insertions(+), 10 deletions(-)

Trivial. Pushed to 2.1.

      reply	other threads:[~2019-03-15 16:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 16:25 Vladimir Davydov
2019-03-15 16:26 ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315162614.d2wh5kbqt7crkmck@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH] test: fix vinyl/errinj failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox