Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix vinyl/deferred_delete failure
Date: Fri, 15 Mar 2019 18:58:12 +0300	[thread overview]
Message-ID: <20190315155812.bk3xq6hffbphifg4@esperanza> (raw)
In-Reply-To: <5433435d6f2cdc0c5524df649f39deb7d02d1dce.1552665465.git.vdavydov.dev@gmail.com>

On Fri, Mar 15, 2019 at 06:57:51PM +0300, Vladimir Davydov wrote:
> The patch fixes the following test failure:
> 
>  | --- vinyl/deferred_delete.result        Fri Mar 15 18:17:05 2019
>  | +++ vinyl/deferred_delete.reject        Fri Mar 15 18:18:18 2019
>  | @@ -577,7 +577,7 @@
>  |  ...
>  |  sk:stat().rows -- ditto
>  |  ---
>  | -- 5
>  | +- 25
>  |  ...
>  |  s:drop()
>  |  ---
> 
> The failure was introduced by commit 6dd0d2fb7e0e ("vinyl: do not apply
> run_count_per_level to the last level"). Due to the commit compaction of
> the secondary index may happen before compaction of the primary index,
> in which case deferred DELETE statements won't make it to the secondary
> index in time against the test expectation. Fix this by making the first
> run big enough to prevent major compaction from kicking in.
> 
> Follow-up #3657
> Closes #4047
> ---
>  test/vinyl/deferred_delete.result   | 36 ++++++++++++++++++++++--------------
>  test/vinyl/deferred_delete.test.lua | 18 ++++++++++++------
>  2 files changed, 34 insertions(+), 20 deletions(-)

Trivial. Pushed to 2.1.

      reply	other threads:[~2019-03-15 15:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 15:57 Vladimir Davydov
2019-03-15 15:58 ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315155812.bk3xq6hffbphifg4@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH] test: fix vinyl/deferred_delete failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox