From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: reset dump watermark after updating memory limit
Date: Fri, 15 Mar 2019 17:12:19 +0300 [thread overview]
Message-ID: <20190315141219.d6nyn5cl4gzoqkcb@esperanza> (raw)
In-Reply-To: <b15773fae61d31d5aa8a586ed4d816632fd1bd4a.1552659087.git.vdavydov.dev@gmail.com>
On Fri, Mar 15, 2019 at 05:11:51PM +0300, Vladimir Davydov wrote:
> The watermark is updated every second anyway, however not updating it
> when the limit is reset results in vinyl/quota test failure:
>
> | --- vinyl/quota.result Thu Mar 14 16:03:54 2019
> | +++ vinyl/quota.reject Fri Mar 15 16:32:44 2019
> | @@ -146,7 +146,7 @@
> | for i = 1, count do s:replace{i, pad} end -- does not trigger dump
> | ---
> | ...
> | -box.stat.vinyl().memory.level0 > count * pad:len()
> | +box.stat.vinyl().memory.level0 > count * pad:len() or box.stat.vinyl()
> | ---
> | - true
> | ...
>
> Closes #3864
> ---
> https://github.com/tarantool/tarantool/issues/3864
>
> src/box/vinyl.c | 2 +-
> src/box/vy_regulator.c | 7 +++++++
> src/box/vy_regulator.h | 6 ++++++
> 3 files changed, 14 insertions(+), 1 deletion(-)
Trivial. Pushed to 2.1.
prev parent reply other threads:[~2019-03-15 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 14:11 Vladimir Davydov
2019-03-15 14:12 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315141219.d6nyn5cl4gzoqkcb@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] vinyl: reset dump watermark after updating memory limit' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox