Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: don't leave open read views after vinyl/iterator
Date: Fri, 15 Mar 2019 17:09:48 +0300	[thread overview]
Message-ID: <20190315140948.47d46ucgf5liu74o@esperanza> (raw)
In-Reply-To: <65061cb4d595bdc09ac1bda50a0dfed090438950.1552658906.git.vdavydov.dev@gmail.com>

On Fri, Mar 15, 2019 at 05:09:03PM +0300, Vladimir Davydov wrote:
> An open iterator may disrupt the following test run, because it may
> prevent dump/compaction from purging stale rows. In particular,
> iterators left by vinyl/iterator result in the following test failure:
> 
>  | --- vinyl/deferred_delete.result        Mon Feb 11 19:14:01 2019
>  | +++ vinyl/deferred_delete.reject        Fri Mar 15 16:21:11 2019
>  | @@ -155,7 +155,7 @@
>  |  ...
>  |  pk:stat().rows -- 5 new REPLACEs
>  |  ---
>  | -- 5
>  | +- 10
>  |  ...
>  |  i1:stat().rows -- 10 old REPLACE + 5 new REPLACEs + 10 deferred DELETEs
>  |  ---
> 
> Fix this by calling the Lua garbage collector to delete all dangling
> iterators in the end of vinyl/iterator test.
> 
> Closes #3862
> ---
> https://github.com/tarantool/tarantool/issues/3862
> 
>  test/vinyl/iterator.result   | 13 +++++++++++++
>  test/vinyl/iterator.test.lua |  6 ++++++
>  2 files changed, 19 insertions(+)

Trivial. Pushed to 2.1.

      reply	other threads:[~2019-03-15 14:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 14:09 Vladimir Davydov
2019-03-15 14:09 ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315140948.47d46ucgf5liu74o@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH] test: don'\''t leave open read views after vinyl/iterator' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox