Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v6 1/3] box: refactor key_def_set_compare_func routine
Date: Thu, 14 Mar 2019 10:04:47 +0300	[thread overview]
Message-ID: <20190314070447.dpdu3aocinfiwrtr@esperanza> (raw)
In-Reply-To: <34cf8ed7af4b1da74a89a260562abe08526cd4e8.1552478226.git.kshcherbatov@tarantool.org>

On Wed, Mar 13, 2019 at 03:15:37PM +0300, Kirill Shcherbatov wrote:
> @@ -1326,6 +1340,6 @@ tuple_compare_with_key_create(const struct key_def *def)
>  void
>  key_def_set_compare_func(struct key_def *def)
>  {
> -	def->tuple_compare = tuple_compare_create(def);
> -	def->tuple_compare_with_key = tuple_compare_with_key_create(def);
> +	key_def_set_tuple_compare(def);
> +	key_def_set_tuple_compare_with_key(def);
>  }

The two functions share a lot of code - all branching is basically the
same. I think we better merge them instead.

  reply	other threads:[~2019-03-14  7:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 12:15 [PATCH v6 0/3] box: introduce hint option for memtx tree index Kirill Shcherbatov
2019-03-13 12:15 ` [PATCH v6 1/3] box: refactor key_def_set_compare_func routine Kirill Shcherbatov
2019-03-14  7:04   ` Vladimir Davydov [this message]
2019-03-15 10:20     ` [tarantool-patches] " Kirill Shcherbatov
2019-03-15 10:55       ` Kirill Shcherbatov
2019-03-19 19:38       ` Vladimir Davydov
2019-03-13 12:15 ` [PATCH v6 2/3] memtx: introduce tuple compare hint Kirill Shcherbatov
2019-03-14  8:19   ` Vladimir Davydov
2019-03-15 10:20     ` [tarantool-patches] " Kirill Shcherbatov
2019-03-20 18:08       ` Vladimir Davydov
2019-03-13 12:15 ` [PATCH v6 3/3] box: introduce multikey indexes Kirill Shcherbatov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190314070447.dpdu3aocinfiwrtr@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v6 1/3] box: refactor key_def_set_compare_func routine' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox