From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] http: fix httpc auto-managed headers
Date: Tue, 12 Mar 2019 11:54:24 +0300 [thread overview]
Message-ID: <20190312085424.7bdiyruwy3oxdrfq@esperanza> (raw)
In-Reply-To: <d7e35661-2c8e-d92d-fda0-d6c4369edf9c@tarantool.org>
On Mon, Mar 11, 2019 at 06:57:54PM +0300, Kirill Shcherbatov wrote:
> The http library intelligently sets the headers "Accept",
> "Connection", "Keep-Alive".
> However, when the user explicitly specified them in the header
> options section of the call argument, they could be written to
> the HTTP request twice.
> We postponed the auto headers setup before https_exececute call.
> Now they are set only if they were not set by the user.
>
> Closes #3955
>
> https://github.com/tarantool/tarantool/tree/kshch/gh-3955-httpc-auto-managed-headers-redefine
> https://github.com/tarantool/tarantool/issues/3955
> ---
> src/httpc.c | 52 +++++++++++++++++++++----------
> src/httpc.h | 23 +++++++++++++-
> src/lua/httpc.c | 6 +---
> test/app-tap/http_client.test.lua | 36 ++++++++++++++++++++-
> 4 files changed, 94 insertions(+), 23 deletions(-)
Pushed to 2.1 and 1.10.
next prev parent reply other threads:[~2019-03-12 8:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:09 [tarantool-patches] [PATCH v1 " Kirill Shcherbatov
2019-02-22 7:39 ` [tarantool-patches] " Kirill Shcherbatov
2019-02-25 7:52 ` Kirill Shcherbatov
2019-02-25 14:17 ` Vladislav Shpilevoy
2019-02-25 15:21 ` Kirill Shcherbatov
2019-03-07 13:51 ` Vladimir Davydov
2019-03-07 14:07 ` Kirill Shcherbatov
2019-03-07 14:32 ` Vladimir Davydov
2019-03-07 14:48 ` Kirill Shcherbatov
2019-03-07 14:53 ` Vladimir Davydov
2019-03-11 9:23 ` [tarantool-patches] Re: [PATCH v2 " Kirill Shcherbatov
2019-03-11 10:02 ` Vladimir Davydov
2019-03-11 15:57 ` Kirill Shcherbatov
2019-03-12 8:54 ` Vladimir Davydov [this message]
2019-03-07 14:07 ` [tarantool-patches] Re: [PATCH v1 " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312085424.7bdiyruwy3oxdrfq@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH v2 1/1] http: fix httpc auto-managed headers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox