From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@freelists.org> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>, Konstantin Osipov <kostja@tarantool.org>, Cyrill Gorcunov <gorcunov@gmail.com> Subject: [PATCH 2/2] lib/core/fiber: Mark stack as unneeded on creation Date: Fri, 8 Mar 2019 00:31:46 +0300 [thread overview] Message-ID: <20190307213146.1476-3-gorcunov@gmail.com> (raw) In-Reply-To: <20190307213146.1476-1-gorcunov@gmail.com> Since we've increased the default stack size we hope the whole 512K won't be used for regular loads thus we mark the stack area as unneeded to minimize rss pressure. Note we do this on fiber creation at the moment, more detailed stack usage analisys will be implemented in another patch series later. Closes #3418 --- src/lib/core/fiber.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c index f16ac873f..a1b261ad4 100644 --- a/src/lib/core/fiber.c +++ b/src/lib/core/fiber.c @@ -749,6 +749,14 @@ fiber_stack_create(struct fiber *fiber, size_t stack_size) fiber->stack_id = VALGRIND_STACK_REGISTER(fiber->stack, (char *)fiber->stack + fiber->stack_size); +#ifndef TARGET_OS_DARWIN + /* + * We don't expect the whole stack usage in regular + * loads, lets try to minimize rss pressure if OS + * allows us. + */ + madvise(fiber->stack, fiber->stack_size, MADV_DONTNEED); +#endif mprotect(guard, page_size, PROT_NONE); return 0; -- 2.20.1
next prev parent reply other threads:[~2019-03-07 21:31 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-07 21:31 [PATCH v4 0/2] lib/core/fiber: Increase default stack size Cyrill Gorcunov 2019-03-07 21:31 ` [PATCH 1/2] " Cyrill Gorcunov 2019-03-07 21:31 ` Cyrill Gorcunov [this message] 2019-03-11 8:18 ` [PATCH 2/2] lib/core/fiber: Mark stack as unneeded on creation Vladimir Davydov 2019-03-11 8:31 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190307213146.1476-3-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH 2/2] lib/core/fiber: Mark stack as unneeded on creation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox