From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] http: fix httpc auto-managed headers
Date: Thu, 7 Mar 2019 17:53:28 +0300 [thread overview]
Message-ID: <20190307145328.ublvmnnyxvowgxl3@esperanza> (raw)
In-Reply-To: <22400748-d82b-16ab-5809-68440cbfb1ef@tarantool.org>
On Thu, Mar 07, 2019 at 05:48:20PM +0300, Kirill Shcherbatov wrote:
> > I don't like how httpc internal API now looks like: one should set
> > headers before the method/url and keepalive options, otherwise he/she
> > risks loosing them. And there isn't a word about this idiosyncrasy
> > anywhere in the comments.
> >
> > Also, splitting request construction into allocation (_new) and
> > method/url initialization (_set_url) looks ugly to me, because no
> > request makes sense without them.
> >
> > May be, we could set default headers in httpc_execute instead?
> No, when those headers are set, they use specific context: like size, idle etx.
You can store them in httpc_request, can't you?
next prev parent reply other threads:[~2019-03-07 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:09 [tarantool-patches] " Kirill Shcherbatov
2019-02-22 7:39 ` [tarantool-patches] " Kirill Shcherbatov
2019-02-25 7:52 ` Kirill Shcherbatov
2019-02-25 14:17 ` Vladislav Shpilevoy
2019-02-25 15:21 ` Kirill Shcherbatov
2019-03-07 13:51 ` Vladimir Davydov
2019-03-07 14:07 ` Kirill Shcherbatov
2019-03-07 14:32 ` Vladimir Davydov
2019-03-07 14:48 ` Kirill Shcherbatov
2019-03-07 14:53 ` Vladimir Davydov [this message]
2019-03-11 9:23 ` [tarantool-patches] Re: [PATCH v2 " Kirill Shcherbatov
2019-03-11 10:02 ` Vladimir Davydov
2019-03-11 15:57 ` Kirill Shcherbatov
2019-03-12 8:54 ` Vladimir Davydov
2019-03-07 14:07 ` [tarantool-patches] Re: [PATCH v1 " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307145328.ublvmnnyxvowgxl3@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH v1 1/1] http: fix httpc auto-managed headers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox