From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org,
Georgy Kirichenko <georgy@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v2 2/3] Put all new rows to the end of journal request
Date: Thu, 7 Mar 2019 14:22:35 +0300 [thread overview]
Message-ID: <20190307112235.GJ5263@chai> (raw)
In-Reply-To: <20190307105321.ru5lpevqnuvg4b6u@esperanza>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/03/07 13:57]:
> > txn->n_rows[stmt->replica_id == instance_id] ++;
>
> TBO I find it hackish.
>
> n_remote_rows / n_rows looks much easier for understanding IMO.
It's n_local_rows and n_remote_rows then. Why do we need the total
and the partial sum then?
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-03-07 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 20:16 [tarantool-patches] [PATCH v2 0/3] Transaction boundaries for applier Georgy Kirichenko
2019-03-06 20:16 ` [tarantool-patches] [PATCH v2 1/3] Applier gets rid of a xstream Georgy Kirichenko
2019-03-07 9:31 ` Vladimir Davydov
2019-03-06 20:16 ` [tarantool-patches] [PATCH v2 2/3] Put all new rows to the end of journal request Georgy Kirichenko
2019-03-07 9:46 ` Vladimir Davydov
2019-03-07 10:38 ` [tarantool-patches] " Konstantin Osipov
2019-03-07 10:53 ` Vladimir Davydov
2019-03-07 11:22 ` Konstantin Osipov [this message]
2019-03-06 20:16 ` [tarantool-patches] [PATCH v2 3/3] Transaction support for applier Georgy Kirichenko
2019-03-07 10:38 ` Vladimir Davydov
2019-03-07 10:40 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307112235.GJ5263@chai \
--to=kostja@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH v2 2/3] Put all new rows to the end of journal request' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox