Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org,
	Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: fix custom delimiter for telnet connection
Date: Thu, 7 Mar 2019 13:16:47 +0300	[thread overview]
Message-ID: <20190307101647.x2qmmzzxmngslmkg@tarantool.org> (raw)
In-Reply-To: <e61f08660a5010156c0bd940d07ba0d27828bf75.1550734259.git.kshcherbatov@tarantool.org>

Hello,

On 21 Feb 10:34, Kirill Shcherbatov wrote:
> Because test-run uses a console connection to run tests, the
> actual string delimiter was the user-specified delimiter
> delim + "\n".
> Since telnet sends \r\n on line break, the updated expression
> delim + "\n"could not be found in a sequence data+delim+"\r\n",
> so delimiter feature did not work at all.
> Added delim + "\r" check along with delim + "\n", that solves the
> described problem and does not violate backward compatibility.
> 
> Closes #2027
> 
> https://github.com/tarantool/tarantool/tree/kshch/gh-2027-telnet-alternative-delimiter
> https://github.com/tarantool/tarantool/issues/2027

I've committed your patch into 2.1 branch.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2019-03-07 10:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21  7:34 [tarantool-patches] " Kirill Shcherbatov
2019-03-05 13:43 ` [tarantool-patches] " Alexander Turenko
2019-03-05 14:41   ` Kirill Shcherbatov
2019-03-05 16:12     ` Alexander Turenko
2019-03-07 10:16 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190307101647.x2qmmzzxmngslmkg@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] box: fix custom delimiter for telnet connection' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox