Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Stanislav Zudin <szudin@tarantool.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>,
	tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v4] Feature request for a new collation
Date: Wed, 6 Mar 2019 11:10:34 +0300	[thread overview]
Message-ID: <20190306081034.GE17432@chai> (raw)
In-Reply-To: <a61361d0-13ad-f4bb-4ea1-1ecd3f5d3eab@tarantool.org>

* Stanislav Zudin <szudin@tarantool.org> [19/03/06 10:24]:
> > I won't be reviewing the rest of this patch, because I don't see much
> > point in adding collations for all those languates now. Up to Kostja.
> Me either. That is why i didn't squash the commits.

I'm fine with these collations, but I think we should have a test
for each and every one, otherwise we can't claim we added them.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-03-06  8:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 11:44 Stanislav Zudin
2019-03-05 14:40 ` Vladimir Davydov
2019-03-06  6:32   ` Stanislav Zudin
2019-03-06  8:10     ` Konstantin Osipov [this message]
2019-03-05 15:41 ` [tarantool-patches] " Konstantin Osipov
2019-03-06  6:36   ` Stanislav Zudin
2019-03-06  8:11     ` Konstantin Osipov
2019-03-06  8:23       ` Stanislav Zudin
2019-03-06  9:48         ` Konstantin Osipov
2019-03-20 15:53           ` Stanislav Zudin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306081034.GE17432@chai \
    --to=kostja@tarantool.org \
    --cc=szudin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] [PATCH v4] Feature request for a new collation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox