From: Konstantin Osipov <kostja@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
tarantool-patches@freelists.org, vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] [PATCH 1/3] core/fiber: Increase default stack size
Date: Wed, 6 Mar 2019 10:30:15 +0300 [thread overview]
Message-ID: <20190306073015.GB17432@chai> (raw)
In-Reply-To: <20190305234336.rwffevewm4ooqun3@tkn_work_nb>
* Alexander Turenko <alexander.turenko@tarantool.org> [19/03/06 10:24]:
Alexander, we plan to make the default stack size configurable.
> On Wed, Mar 06, 2019 at 01:38:52AM +0300, Cyrill Gorcunov wrote:
> > The default 64K stack size used for years become too small
> > for modern distors (Fedora 29 and etc) where third party libraries
> > (such as ncurses) started to use 64K for own buffers and we get
> > SIGSGV early without reaching interactive console phase.
> >
> > Thus we increase default size up to 256K which should fit
> > for common case. Later we will make this value configurable
> > to address arbitrary stack sizes without a need to rebuild
> > the code.
> >
> > Note the values are switched to 4K page granularity for sake
> > of future modifications -- we gonna manipulate pages to
> > relax rss usage if OS allows.
> >
> > Closes #3418
> > ---
> > src/lib/core/fiber.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
> > index abd6c6b11..d4d16c05e 100644
> > --- a/src/lib/core/fiber.c
> > +++ b/src/lib/core/fiber.c
> > @@ -92,10 +92,10 @@ static size_t page_size;
> > static int stack_direction;
> >
> > enum {
> > - /* The minimum allowable fiber stack size in bytes */
> > - FIBER_STACK_SIZE_MINIMAL = 16384,
> > - /* Default fiber stack size in bytes */
> > - FIBER_STACK_SIZE_DEFAULT = 65536
> > + /* The minimum allowable fiber stack size in 4K page */
> > + FIBER_STACK_SIZE_MINIMAL = 4 << 12,
> > + /* Default fiber stack size in 4K page */
> > + FIBER_STACK_SIZE_DEFAULT = 64 << 12,
>
> I recently looked at #3564 and observed that 256 KiB of stack is not
> enough for our http client (the wrapper around libcurl). I bisected how
> much it requeres and found that it fails with 448 KiB, but succeeds with
> 480 KiB. I just tried the following case with different
> FIBER_STACK_SIZE_DEFAULT constants on our tt-mac machine:
>
> ./src/tar
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-03-06 7:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 22:38 [PATCH v3 0/3] core/fiber: Rework stack management Cyrill Gorcunov
2019-03-05 22:38 ` [PATCH 1/3] core/fiber: Increase default stack size Cyrill Gorcunov
2019-03-05 23:43 ` [tarantool-patches] " Alexander Turenko
2019-03-06 7:09 ` Cyrill Gorcunov
2019-03-06 7:30 ` Konstantin Osipov [this message]
2019-03-05 22:38 ` [PATCH 2/3] core/fiber: Mark stack as unneeded on creation Cyrill Gorcunov
2019-03-05 22:38 ` [PATCH 3/3] core/fiber: Put watermarks into stack to track its usage Cyrill Gorcunov
2019-03-06 18:05 ` Vladimir Davydov
2019-03-06 19:03 ` Cyrill Gorcunov
2019-03-07 8:27 ` Vladimir Davydov
2019-03-07 9:04 ` Cyrill Gorcunov
2019-03-07 9:20 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306073015.GB17432@chai \
--to=kostja@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] [PATCH 1/3] core/fiber: Increase default stack size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox