From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Stanislav Zudin <szudin@tarantool.org> Cc: tarantool-patches@freelists.org, kostja@tarantool.org Subject: Re: [tarantool-patches] [PATCH v4] Feature request for a new collation Date: Tue, 5 Mar 2019 17:40:04 +0300 [thread overview] Message-ID: <20190305144004.fvbm2mfwvyfsh76b@esperanza> (raw) In-Reply-To: <20190305114431.31311-1-szudin@tarantool.org> On Tue, Mar 05, 2019 at 02:44:31PM +0300, Stanislav Zudin wrote: > Adds a new set of default collations. > The collation 'unicode_ky_s1' supports the difference > between Cyrillic letters 'Е' and 'Ё'. The standard case insensitive > collation ('unicode_ci') doesn't distinguish these letters. > > Closes #4007 > --- > Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-4007-new-default-collation-2.1 > Issue: https://github.com/tarantool/tarantool/issues/4007 Whenever you resubmit a patch, please add a brief changelog here to point what have changed. It jogs my memory. Something like this would be fine: Changes in v4: - Add collations for other languages Changes in v3: - Upgrade schema to 2.1.2 instead of using 2.1.0. ... > > src/box/bootstrap.snap | Bin 1867 -> 4485 bytes > src/box/lua/upgrade.lua | 109 ++++++- > src/coll_def.h | 2 +- > test/box-py/bootstrap.result | 2 +- > test/box/ddl.result | 560 +++++++++++++++++++++++++++++++- > test/box/net.box.result | 2 +- > test/sql-tap/collation.test.lua | 280 +++++++++++++++- > test/sql/collation.result | 4 +- > test/sql/collation.test.lua | 4 +- > 9 files changed, 943 insertions(+), 20 deletions(-) > > diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua > index 09af2e20d..58b5d47cc 100644 > --- a/src/box/lua/upgrade.lua > +++ b/src/box/lua/upgrade.lua > @@ -615,7 +615,114 @@ local function upgrade_to_2_1_0() > end > > local function upgrade_to_2_1_2() > - box.space._collation:replace{4, "unicode_ru_s2", ADMIN, "ICU", "ru_RU", {strength='secondary'}} Apparently, this patch is based on the previous version of the same patch. Please don't do that. Squash it instead (see `git rebase -i` and `git push -f`). I won't be reviewing the rest of this patch, because I don't see much point in adding collations for all those languates now. Up to Kostja.
next prev parent reply other threads:[~2019-03-05 14:40 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-05 11:44 Stanislav Zudin 2019-03-05 14:40 ` Vladimir Davydov [this message] 2019-03-06 6:32 ` Stanislav Zudin 2019-03-06 8:10 ` Konstantin Osipov 2019-03-05 15:41 ` [tarantool-patches] " Konstantin Osipov 2019-03-06 6:36 ` Stanislav Zudin 2019-03-06 8:11 ` Konstantin Osipov 2019-03-06 8:23 ` Stanislav Zudin 2019-03-06 9:48 ` Konstantin Osipov 2019-03-20 15:53 ` Stanislav Zudin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190305144004.fvbm2mfwvyfsh76b@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=szudin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v4] Feature request for a new collation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox