From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [rfc 4/4] core/fiber: Shrink stack when recycling
Date: Tue, 5 Mar 2019 12:32:42 +0300 [thread overview]
Message-ID: <20190305093242.GC21955@chai> (raw)
In-Reply-To: <20190305084110.GM13301@uranus.lan>
* Cyrill Gorcunov <gorcunov@gmail.com> [19/03/05 11:41]:
> On Tue, Mar 05, 2019 at 11:30:48AM +0300, Konstantin Osipov wrote:
> > * Cyrill Gorcunov <gorcunov@gmail.com> [19/03/03 23:25]:
> > > +#define wmark_freeze(_pp) do { *((uintptr_t *)(_pp)) |= (uintptr_t)1; } while (0)
> > > +#define wmark_frozen(_p) ((uintptr_t)(_p) & (uintptr_t)1)
> >
> > Why not static inline? A comment would help. Usually the name for
> > function returning true/false contains "is", e.g. wmark_is_frozen().
>
> Well, surely we can use inlines here, I simply tried to make less code.
> Seriously fiber.c looks too bloating. Maybe we should move all this
> machinery into fiber-stack.cc?
I am OK with moving things out (we prefer underscore to dash in
file names though), but I tend to count code lines in the count of
generated processor instructions, not characters/lines in a source
file.
>
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
prev parent reply other threads:[~2019-03-05 9:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 12:55 [rfc 0/4] fiber/stack: Increase stack size and shrink rss usage Cyrill Gorcunov
2019-03-02 12:55 ` [rfc 1/4] core/fiber: Increase default stack size Cyrill Gorcunov
2019-03-02 12:55 ` [rfc 2/4] core/fiber: Mark stack as unneeded on creation Cyrill Gorcunov
2019-03-02 12:55 ` [rfc 3/4] core/fiber: Put static watermark into stack to track its usage Cyrill Gorcunov
2019-03-05 8:08 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 8:17 ` Cyrill Gorcunov
2019-03-05 8:10 ` Konstantin Osipov
2019-03-05 8:14 ` Cyrill Gorcunov
2019-03-05 19:17 ` Cyrill Gorcunov
2019-03-05 8:20 ` Konstantin Osipov
2019-03-05 8:27 ` Cyrill Gorcunov
2019-03-02 12:55 ` [rfc 4/4] core/fiber: Shrink stack when recycling Cyrill Gorcunov
2019-03-05 8:30 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 8:41 ` Cyrill Gorcunov
2019-03-05 9:32 ` Konstantin Osipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305093242.GC21955@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [rfc 4/4] core/fiber: Shrink stack when recycling' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox