From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v3 5/9] sql: remove field zErrMsg of struct Parse
Date: Tue, 5 Mar 2019 11:43:08 +0300 [thread overview]
Message-ID: <20190305084308.GR21955@chai> (raw)
In-Reply-To: <29c77ea3f8463994b98bcb23653f901cf46e472a.1551530224.git.imeevma@gmail.com>
* imeevma@tarantool.org <imeevma@tarantool.org> [19/03/03 23:25]:
> Hi! Thank you for review. My answers and new patch below. There
> won't be diff between versions as I completely rewritten this
> patch after placein it after removing of rc and nErr.
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-03-05 8:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 13:07 [tarantool-patches] [PATCH v3 0/9] sql: use diag_set() for errors in SQL imeevma
2019-03-02 13:07 ` [tarantool-patches] [PATCH v3 1/9] sql: rework syntax errors imeevma
2019-03-04 17:47 ` [tarantool-patches] " n.pettik
2019-03-05 8:31 ` Konstantin Osipov
2019-03-02 13:07 ` [tarantool-patches] [PATCH v3 2/9] sql: save SQL parser errors in diag_set() imeevma
2019-03-05 8:40 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 9:06 ` n.pettik
2019-03-02 13:07 ` [tarantool-patches] [PATCH v3 3/9] sql: remove field nErr of struct Parse imeevma
2019-03-05 8:41 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 9:06 ` n.pettik
2019-03-02 13:07 ` [tarantool-patches] [PATCH v3 4/9] sql: remove field rc " imeevma
2019-03-05 8:42 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 9:06 ` n.pettik
2019-03-02 13:07 ` [tarantool-patches] [PATCH v3 5/9] sql: remove field zErrMsg " imeevma
2019-03-05 8:43 ` Konstantin Osipov [this message]
2019-03-05 9:06 ` [tarantool-patches] " n.pettik
2019-03-02 13:07 ` [tarantool-patches] [PATCH v3 6/9] sql: rework six syntax errors imeevma
2019-03-05 8:45 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 9:07 ` n.pettik
2019-03-02 13:08 ` [tarantool-patches] [PATCH v3 7/9] sql: rework four semantic errors imeevma
2019-03-05 8:46 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 9:16 ` n.pettik
2019-03-02 13:08 ` [tarantool-patches] [PATCH v3 8/9] sql: rework three errors of "unsupported" type imeevma
2019-03-05 8:47 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 9:34 ` n.pettik
2019-03-05 9:43 ` Konstantin Osipov
2019-03-02 13:08 ` [tarantool-patches] [PATCH v3 9/9] sql: remove sqlErrorMsg() imeevma
2019-03-05 8:48 ` [tarantool-patches] " Konstantin Osipov
2019-03-05 12:16 ` n.pettik
2019-03-05 15:44 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305084308.GR21955@chai \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3 5/9] sql: remove field zErrMsg of struct Parse' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox